Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hash#slice from code. #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

hkmaly
Copy link

@hkmaly hkmaly commented Sep 22, 2021

Should fix #83

@nesquena
Copy link
Member

Did you run the tests locally and do they pass? @hkmaly

@hkmaly
Copy link
Author

hkmaly commented Sep 25, 2021

Sorry. As I mentioned, they didn't. And by "didn't" I mean I had failures even on tests having nothing to do with the change: 103 runs, 155 assertions, 31 failures, 6 errors, 0 skips including some incorrect encoding and "undefined method `cleanup_tubes!" ... there must be something I did incorrectly or more problems with older ruby than just the ones related to slice.

@nesquena
Copy link
Member

Hmm okay, thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Hash#slice forces ruby 2.5+
2 participants