Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmt tests misconfigured #159

Open
LecrisUT opened this issue Jun 8, 2023 · 5 comments · May be fixed by #160
Open

tmt tests misconfigured #159

LecrisUT opened this issue Jun 8, 2023 · 5 comments · May be fixed by #160

Comments

@LecrisUT
Copy link
Contributor

LecrisUT commented Jun 8, 2023

The tests defined in /plans/tmt are running the tests of tmt, not those of this repo. There is a bit of overlap, but shouldn't there be tests defined for this repo as well that run make test or the individual test files?

@sopos
Copy link
Member

sopos commented Jun 9, 2023

Right, there are no tests like these written specifically for beakerlib. There's and internal test suite make test but there are still some failures there. That's our debt.

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Jun 9, 2023

If I enable these tests, can someone take a look at them to fix them?

@sopos
Copy link
Member

sopos commented Jun 9, 2023

there's not much capacity for that, currently

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Jun 9, 2023

I think we can do it with:

# /palns/unit_tests.fmf
summary: Unit tests for beakerlib
discover:
  how: shell
  tests:
  - name: Beakerlib unit tests
    test: make test

@sopos
Copy link
Member

sopos commented Jun 9, 2023

yeah, we do not break anything by enabling it

@LecrisUT LecrisUT linked a pull request Jun 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants