-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rxjs_1.Observable.create(...).finally is not a function #23
Comments
Hi @gregdumb! From the error message, it's not clear what's throwing the error. Think you can put a self-contained, reproducible example in a zip (or better yet, on Stackblitz or Codepen) so I can reproduce what you're seeing? As a first step, how are you including RxJS in your build? |
You made me realize that I had installed RxJS ^6.0.0, so I tried with ^5.0.0 and that works! Is 6 not supported? Edit: made branch here that demonstrates the break. |
Good to hear! It seems like Rx6 is still in RC, but in the meantime I will do a couple of things:
|
@gregdumb Undux 4.3 is shipped, with out of the box support for both Rx6 and Rx5. |
Wow sweet! Appreciate the fast turnaround. |
Possible noob question, I have the minimum possible Undux store setup but when I call withStore I get that error.
My store (taken from readme example):
Where I use withStore:
The error (x2):
I'm using regular JS with create-react-app, not typescript; is that the problem? Any advice is much appreciated.
(Also great library, exactly what I was looking for after the verbosity of Redux!)
The text was updated successfully, but these errors were encountered: