Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game Buttons should remove accessible buttons on destroy #495

Open
FostUK opened this issue Aug 4, 2021 · 2 comments
Open

Game Buttons should remove accessible buttons on destroy #495

FostUK opened this issue Aug 4, 2021 · 2 comments

Comments

@FostUK
Copy link
Contributor

FostUK commented Aug 4, 2021

  • In accessibilify.js we hook into the destroy method of an event. The accessible button should also destroy itself here and clean up any arrays it is part of.
  • sys.accessibleButtons is for gameButttons and should be renamed gameButtons
  • removeButton should be removed as it is not used internally and agencies can just destroy their accessibilified game objects safely with the above changes.
@binhbui
Copy link
Contributor

binhbui commented Aug 4, 2021

removeButton is used by storytime right?

@AdamXA
Copy link
Member

AdamXA commented Aug 4, 2021

I guess the idea will be that future versions of Genie will make it so removeButton is not required anymore, just destroy the object and the accessibilify stuff is cleaned up automatically.

Storytime can use the old version of Genie and continue with removeButton, or update to a new version of Genie with this change in and stop calling removeButton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants