Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Establish community convention for "side-effecting"-only requires #175

Open
borkdude opened this issue Jun 7, 2019 · 2 comments
Open

Establish community convention for "side-effecting"-only requires #175

borkdude opened this issue Jun 7, 2019 · 2 comments

Comments

@borkdude
Copy link
Sponsor

borkdude commented Jun 7, 2019

Please chime on this discussion:

clj-kondo/clj-kondo#241

After processing the feedback, we can extract a style guide "rule" from this.
@bbatsov
Copy link
Owner

bbatsov commented Dec 4, 2020

Would you be interested in distilling a rule for this now that dust has settled?

@borkdude
Copy link
Sponsor Author

borkdude commented Dec 4, 2020

@bbatsov The convention that clj-kondo ended up adopting:

If a namespace has been required without :refer or :alias then it is assumed to be required for side effects and will not be reported as unused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbatsov @borkdude