Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give examples for changing-state-fns-with-exclamation-mark #135

Open
danielcompton opened this issue Jun 28, 2016 · 0 comments
Open

Give examples for changing-state-fns-with-exclamation-mark #135

danielcompton opened this issue Jun 28, 2016 · 0 comments

Comments

@danielcompton
Copy link
Collaborator

danielcompton commented Jun 28, 2016

Reading https://github.com/bbatsov/clojure-style-guide#changing-state-fns-with-exclamation-mark, it's not clear to me whether things like database calls should have !s on them. They are changing state, and not necessarily retryable in STM transactions, but it's not super clear what the boundaries are here. It would be good to put some concrete examples here of what is in and what is out.

e.g.

In
STM
Database mutations
Saving files to disk

Out
Logging
???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant