Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish new release? #68

Open
5225225 opened this issue Jul 31, 2022 · 1 comment
Open

Publish new release? #68

5225225 opened this issue Jul 31, 2022 · 1 comment

Comments

@5225225
Copy link

5225225 commented Jul 31, 2022

Hello!

I'm coming to this project from rust-lang/rust#99389 , where some stricter checks of creation of uninitialized data is being tested out, and the crates.io version of this crate ran into the checks. It looks like 0.2.0 on crates.io has out of date dependencies, eventually leading to an out of date smallvec.

I tested the proposed change on master, and it ran fine, so the only thing that's needed is a new release to be made.

@jayvdb
Copy link

jayvdb commented Aug 27, 2023

Compiling the published crate using rust stable results in

...
   Compiling Boa v0.5.1
error[E0282]: type annotations needed
  --> /home/jayvdb/.cargo/registry/src/index.crates.io-6f17d22bba15001f/Boa-0.5.1/src/lib/builtins/array.rs:23:11
   |
23 |     array.borrow().set_internal_slot(
   |           ^^^^^^   ----------------- type must be known at this point
   |
help: try using a fully qualified path to specify the expected types
   |
23 |     <Gc<ValueData> as Borrow<Borrowed>>::borrow(&array).set_internal_slot(
   |     +++++++++++++++++++++++++++++++++++++++++++++     ~

Doesnt occur when installing from the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants