Skip to content

Commit 02923f5

Browse files
authored
Merge pull request #551 from bavc/clarify-tooltip-barchart
clarifies current value in bar chart tooltip
2 parents 25f45f8 + 5d8cf82 commit 02923f5

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

Source/GUI/Plot.h

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ class PlotSeriesData : public QObject, public QwtPointSeriesData
297297
auto plotGroup = m_plotGroup;
298298

299299
engine.globalObject().setProperty("yHalf", (::pow(2, bitdepth)) / 2);
300-
autocomplete << QPair<QString, QString>("yHalf", QString("2^(bitdepth) / 2 = %1").arg(engine.globalObject().property("yHalf").toInt()));
300+
autocomplete << QPair<QString, QString>("yHalf", QString("2^(bitdepth) / 2 (Current value = %1)").arg(engine.globalObject().property("yHalf").toInt()));
301301

302302
auto pow2 = engine.evaluate("function(value) { return Math.pow(value, 2); }");
303303
engine.globalObject().setProperty("pow2", pow2);
@@ -318,36 +318,36 @@ class PlotSeriesData : public QObject, public QwtPointSeriesData
318318
if(plotGroup == Group_Y || plotGroup == Group_U || plotGroup == Group_V || plotGroup == Group_YDiff || plotGroup == Group_UDiff || plotGroup == Group_VDiff)
319319
{
320320
engine.globalObject().setProperty("maxval", ::pow(2, bitdepth));
321-
autocomplete << QPair<QString, QString>("maxval", QString("2^bitdepth = %1").arg(engine.globalObject().property("maxval").toInt()));
321+
autocomplete << QPair<QString, QString>("maxval", QString("2^bitdepth (Current value = %1)").arg(engine.globalObject().property("maxval").toInt()));
322322

323323
engine.globalObject().setProperty("minval", 0);
324324
autocomplete << QPair<QString, QString>("minval", QString("0"));
325325

326326
if(plotGroup == Group_Y || plotGroup == Group_YDiff)
327327
{
328328
engine.globalObject().setProperty("broadcastmaxval", 235 * (::pow(2, bitdepth - 8)));
329-
autocomplete << QPair<QString, QString>("broadcastmaxval", QString("235 * (2^(bitdepth - 8)) = %1").arg(engine.globalObject().property("broadcastmaxval").toInt()));
329+
autocomplete << QPair<QString, QString>("broadcastmaxval", QString("235 * (2^(bitdepth - 8)) (Current value = %1)").arg(engine.globalObject().property("broadcastmaxval").toInt()));
330330

331331
} else if(plotGroup == Group_U || plotGroup == Group_UDiff || plotGroup == Group_V || plotGroup == Group_VDiff)
332332
{
333333
engine.globalObject().setProperty("broadcastmaxval", 240 * (::pow(2, bitdepth - 8)));
334-
autocomplete << QPair<QString, QString>("broadcastmaxval", QString("240 * (2^(bitdepth - 8)) = %1").arg(engine.globalObject().property("broadcastmaxval").toInt()));
334+
autocomplete << QPair<QString, QString>("broadcastmaxval", QString("240 * (2^(bitdepth - 8)) (Current value = %1)").arg(engine.globalObject().property("broadcastmaxval").toInt()));
335335
}
336336

337337
engine.globalObject().setProperty("broadcastminval", 16 * (::pow(2, bitdepth - 8)));
338-
autocomplete << QPair<QString, QString>("broadcastminval", QString("16 * (2^(bitdepth - 8)) = %1").arg(engine.globalObject().property("broadcastminval").toInt()));
338+
autocomplete << QPair<QString, QString>("broadcastminval", QString("16 * (2^(bitdepth - 8)) (Current value = %1)").arg(engine.globalObject().property("broadcastminval").toInt()));
339339
} else if(plotGroup == Group_Sat)
340340
{
341341
engine.globalObject().setProperty("satmax", sqrt(2 * ::pow(::pow(2, bitdepth)/2,2) ));
342-
autocomplete << QPair<QString, QString>("satmax", QString("sqrt(2*((2^bitdepth)/2)^2) = %1").arg(engine.globalObject().property("satmax").toInt()));
342+
autocomplete << QPair<QString, QString>("satmax", QString("sqrt(2*((2^bitdepth)/2)^2) (Current value = %1)").arg(engine.globalObject().property("satmax").toInt()));
343343

344344
/* use the hypotenuse of green plotted in Cb/Cr based on ITU BT.601 values as the satyuvmax */
345345
engine.globalObject().setProperty("satyuvmax", sqrt(::pow(-74.203,2)+::pow(93.786,2)) * (::pow(2, bitdepth - 8)));
346-
autocomplete << QPair<QString, QString>("satyuvmax", QString("sqrt(-74.203^2+93.786^2) * (2^(bitdepth - 8)) = %1").arg(engine.globalObject().property("satyuvmax").toInt()));
346+
autocomplete << QPair<QString, QString>("satyuvmax", QString("sqrt(-74.203^2+93.786^2) * (2^(bitdepth - 8)) (Current value = %1)").arg(engine.globalObject().property("satyuvmax").toInt()));
347347

348348
/* 75% of satyuvmax as satbroadcastmax */
349349
engine.globalObject().setProperty("satbroadcastmax", sqrt(::pow(-74.203,2)+::pow(93.786,2)) * (::pow(2, bitdepth - 8)) * 0.75);
350-
autocomplete << QPair<QString, QString>("satbroadcastmax", QString("sqrt(-74.203^2+93.786^2) * (2^(bitdepth - 8)) * 0.75 = %1").arg(engine.globalObject().property("satbroadcastmax").toInt()));
350+
autocomplete << QPair<QString, QString>("satbroadcastmax", QString("sqrt(-74.203^2+93.786^2) * (2^(bitdepth - 8)) * 0.75 (Current value = %1)").arg(engine.globalObject().property("satbroadcastmax").toInt()));
351351
}
352352

353353
engine.setProperty("autocomplete", QVariant::fromValue(autocomplete));

0 commit comments

Comments
 (0)