Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip URLs that contain "{{deadlink" #79

Open
nicolas-raoul opened this issue Apr 11, 2018 · 4 comments
Open

Skip URLs that contain "{{deadlink" #79

nicolas-raoul opened this issue Apr 11, 2018 · 4 comments
Labels
enhancement input up-for-grabs

Comments

@nicolas-raoul
Copy link
Collaborator

Example URL at https://ru.wikivoyage.org/wiki/%D0%AF%D1%80%D0%BE%D1%81%D0%BB%D0%B0%D0%B2%D0%BB%D1%8C:

http://www.yubil.yar.ru {{dead link|July 2017}}

We should ignore such (potentially broken) links. I mean, we should pretend the value was empty.
That will improve the overall quality of the output.
@shaikfareed46
Copy link

Hey i would like to take this bug and explore

@nicolas-raoul
Copy link
Collaborator Author

nicolas-raoul commented Apr 20, 2018 •
edited
Loading

@shaikfareed46 It is yours, thanks! :-)

shaikfareed46 added a commit to shaikfareed46/wikivoyage-listings that referenced this issue Apr 26, 2018
@shaikfareed46
Changes related to issue baturin#79 deadlinks
0054f41
shaikfareed46 added a commit to shaikfareed46/wikivoyage-listings that referenced this issue Apr 27, 2018
@shaikfareed46
Made changes for issue baturin#79
b65db89
shaikfareed46 added a commit to shaikfareed46/wikivoyage-listings that referenced this issue May 1, 2018
@shaikfareed46
Fixing failing test cases for baturin#79
0b8fb7d
@kieransukachevin
Copy link

Hey is this still open?

@nicolas-raoul
Copy link
Collaborator Author

@kieransukachevin Sorry I have not taken the time to check. Would you mind testing @shaikfareed46's commits? If it works, please make a pull request. Thanks a lot :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement input up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicolas-raoul @shaikfareed46 @kieransukachevin