Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include diplomatic representation's operator, and whether it is an embassy or consulate #43

Open
nicolas-raoul opened this issue Sep 7, 2017 · 0 comments

Comments

@nicolas-raoul
Copy link
Collaborator

nicolas-raoul commented Sep 7, 2017

This is phase 2 following Dario's great work at #23.

The operator of the USA consulate in Frankfurt is the USA.

In the English Wikivoyage it is in the "Embassies" section, so we know that it is a consulate: https://en.wikivoyage.org/wiki/Frankfurt#Cope

We should add an "operator" property to Listing.java and accordingly a column in the CSV.
Also, when we know whether a diplomatic-representation is a embassy or consulate, we should set the listing type to "embassy" or "consulate". When we don't know, "diplomatic-representation" is fine.

Other examples: https://en.wikivoyage.org/wiki/Lyon https://en.wikivoyage.org/wiki/Paris

Some Wikivoyages seem to not make the difference: https://fr.wikivoyage.org/wiki/Lyon#Repr.C3.A9sentations_diplomatiques

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant