Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize variant values on generation #9

Open
moacode opened this issue Dec 8, 2020 · 2 comments
Open

Normalize variant values on generation #9

moacode opened this issue Dec 8, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@moacode
Copy link

moacode commented Dec 8, 2020

We need to ensure the variant generation method matches how Craft Commerce create their variants, namely normalizing the various values such as price, weight, stock etc.

We can use Craft Commerce's normalization methods for this.
@moacode
Copy link
Author

moacode commented Dec 8, 2020

Estimate: 30mins to an hour.

@moacode moacode added the enhancement New feature or request label Dec 8, 2020
@moacode
Copy link
Author

moacode commented Dec 9, 2020

@judereid checkout this helper method that uses a localization helper to normalize values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@moacode