Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve terminology #13

Open
moacode opened this issue Dec 8, 2020 · 2 comments
Open

Improve terminology #13

moacode opened this issue Dec 8, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@moacode
Copy link

moacode commented Dec 8, 2020

We need to ensure consistent terminology is used across the front end generation UI. A classic example is sku vs SKU. Using Craft's JS translations could be a good option here.

@moacode
Copy link
Author

moacode commented Dec 8, 2020

Estimate: A few hours if the above approach can be used.

@moacode moacode added the enhancement New feature or request label Dec 8, 2020
@moacode
Copy link
Author

moacode commented Dec 10, 2020

@judereid I've added translations which can be found in src/translations/en/craft-commerce-untitled.php. Note that the translation text needs to be loaded into the view which is done from the registerAssetFiles() method within the asset bundle (src/assetbundles/craftcommerceuntitled/CraftCommerceUntitledAsset.php).

At the moment I've just "translated" sku --> SKU but there may be other terms we need to translate so will leave this open until the plugin is finalised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant