Add settings parameter streaming.text.extendSegmentedCues (Dash-Industry-Forum#4112)

* fix: extend last cue endTime in case of same cue but segmented over consecutive segments or chunks

* fix: extend last cue endTime in case of same cue but segmented over consecutive segments or chunks

* fix unit tests

* fix: extend last cue endTime in case of same cue but segmented over consecutive segments or chunks

* remove console.log

* Add setting parameters streaming.text.extendSegmentedCues to enable/disable patching of segmented cues

* Fix extendSegmentedCues jsdoc

Author: bbert

index.d.ts

@@ -228,6 +228,7 @@ declare namespace dashjs {
             },
             text?: {
                 defaultEnabled?: boolean,
+                extendSegmentedCues?: boolean,
                 webvtt?: {
                     customRenderingEnabled?: number
                 }

src/core/Settings.js

@@ -139,6 +139,7 @@ import Events from './events/Events';
  *            },
  *            text: {
  *                defaultEnabled: true,
+ *                extendSegmentedCues: true,
  *                webvtt: {
  *                    customRenderingEnabled: false
  *                }
@@ -452,6 +453,8 @@ import Events from './events/Events';
  * @typedef {Object} Text
  * @property {number} [defaultEnabled=true]
  * Enable/disable subtitle rendering by default.
+ * @property {boolean} [extendSegmentedCues=true]
+ * Enable/disable patching of segmented cues in order to merge as a single cue by extending cue end time.
  * @property {object} [webvtt={customRenderingEnabled=false}]
  * Enables the custom rendering for WebVTT captions. For details refer to the "Subtitles and Captions" sample section of dash.js.
  * Custom WebVTT rendering requires the external library vtt.js that can be found in the contrib folder.
@@ -865,6 +868,7 @@ function Settings() {
             },
             text: {
                 defaultEnabled: true,
+                extendSegmentedCues: true,
                 webvtt: {
                     customRenderingEnabled: false
                 }

src/streaming/text/TextTracks.js

@@ -421,6 +421,9 @@ function TextTracks(config) {
     }
 
     function _extendLastCue(cue, track) {
+        if (!settings.get().streaming.text.extendSegmentedCues) {
+            return false;
+        }
         if (!track.cues || track.cues.length === 0) {
             return false;
         }