Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local docker runs should honor resource specifications in config #209

Open
pankajroark opened this issue Feb 6, 2023 · 3 comments
Open
Labels
good first issue Good for newcomers

Comments

@pankajroark
Copy link
Collaborator

We don't enforce any limits right now, but we should to mimic production deployments and let one tune these settings well locally.

@pankajroark pankajroark added the good first issue Good for newcomers label Feb 6, 2023
@pankajroark
Copy link
Collaborator Author

@bolasim
Copy link
Collaborator

bolasim commented Feb 14, 2023

What's the expected behavior around the use_gpu flag and the new accelerator spec?

@pankajroark
Copy link
Collaborator Author

What's the expected behavior around the use_gpu flag and the new accelerator spec?

Good point, this needs more thought. It's unlikely that someone would have the same accelerator locally as they have in a deployed environment. My worry is, in trying to enforce strict use of specs we may make local dev harder. I think we should honor CPU and memory, as those seem like easy pickings. We can revisit use_gpu and accelerator at a later point, in the meanwhile we could show a message indicating any mismatch of gpu/accelerator settings in the docker environment used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Triage
Development

No branches or pull requests

2 participants