Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truss handle should reflect changes made to truss after it was created #123

Open
pankajroark opened this issue Nov 15, 2022 · 4 comments
Open

Comments

@pankajroark
Copy link
Collaborator

Typical flow is like this:

handle = mk_truss(model, target_directory='some_dir')
# Make changes to truss, like modify `model.py`
# Recreate handle to load changes
handle = from_directory('some_dir')

That last step should is easy to forget and should not be needed. It will be great if the handle automatically reflects changes tot he underlying truss.

@bolasim
Copy link
Collaborator

bolasim commented Feb 14, 2023

In my experience, modifying model.py and re-runing handle.predict works with the now code withouth needing to call truss.load("...").

Is there something else that we want to make sure if reflected (maybe configs? requirements?)

@pankajroark
Copy link
Collaborator Author

When we create the truss handle we also create the truss_spec, which reads in the config. This config in truss_handle would go out of sync when the config.yaml is modified on disk. We'd need to orchestrate things, so that there's some kind of revalidation/reload when any truss_handle methods are called.

@bolasim
Copy link
Collaborator

bolasim commented Feb 24, 2023

Ah interesting. Do we have to run a kind of filewatcher, like FastAPI does for fast reload?

@bolasim
Copy link
Collaborator

bolasim commented Jun 27, 2023

Do we still need this as we move to a more cli focused flow, over a notebook focused flow?

@bolasim bolasim moved this to Backlog in Truss 0.10 project Jun 27, 2023
@bolasim bolasim moved this from Backlog to Triage in Truss 0.10 project Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

2 participants