Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[infra] [python] [v2] Revisar testes do pacote Python #1691

Open
5 of 13 tasks
gabriel-milan opened this issue Oct 30, 2023 · 3 comments · Fixed by #1740
Open
5 of 13 tasks

[infra] [python] [v2] Revisar testes do pacote Python #1691

gabriel-milan opened this issue Oct 30, 2023 · 3 comments · Fixed by #1740
Assignees
@isabelmeister
Labels
infra New CLI version or infra related issues python

Comments

@gabriel-milan
Copy link
Member

gabriel-milan commented Oct 30, 2023 •
edited by isabelmeister
Loading

Muitos testes não fazem mais sentido na nova versão do pacote e estão quebrando. É necessário verificar, removê-los se não fizer mais sentido e escrever novos para cobrir maior parte do pacote.

Sugerido em #1684
Relacionado a #1678

  • Discovery
  • Configurar o CI para rodar os testes
    (sdk/.github/workflows/ci-python.yml)

Root

   Cache*

Core

Cache*
_init*
  • base (18)*

Download

Cache*
_init*
  • download (17)
  • metadata (8)

Upload -> A princípio não essencial

Cache*
_init*
  • connection (9)
  • dataset (10)
  • datatypes (4)
  • storage (9)
  • table (22)
  • utils (2)

Root

_init*
_version*

  • _warnings (4)
  • backend (12)
    - [x] _simplify_response
    - [x] _execute_query
    - [x] _get_dataset_id_from_name
    - [x] _get_table_id_from_name
    - [x] _get_dataset_config
    - [x] _get_table_config
    constants*
    exceptions*

nome_do_arquivo -> Não testável || Vazio*
@gabriel-milan gabriel-milan added the bug Something isn't working label Oct 30, 2023
@gabriel-milan gabriel-milan added infra New CLI version or infra related issues python and removed bug Something isn't working labels Oct 30, 2023
@vncsna vncsna moved this to 🏁 Priorizado in Engenharia-SRE-UX Jan 13, 2024
@gabriel-milan gabriel-milan mentioned this issue Feb 20, 2024
Closed
@laura-l-amaral laura-l-amaral mentioned this issue Apr 10, 2024
Closed
@vncsna vncsna moved this from Priorizado to Em andamento in Engenharia-SRE-UX Apr 26, 2024
@laura-l-amaral laura-l-amaral moved this from Em andamento to Priorizado in Engenharia-SRE-UX Apr 29, 2024
@vncsna vncsna moved this from Priorizado to Em andamento in Engenharia-SRE-UX Apr 29, 2024
@laura-l-amaral laura-l-amaral moved this from Em andamento to Backlog in Engenharia-SRE-UX Jul 16, 2024
@laura-l-amaral laura-l-amaral moved this from Backlog to Priorizado in Engenharia-SRE-UX Jul 16, 2024
@nayaramrsc nayaramrsc moved this from Priorizado to Backlog in Engenharia-SRE-UX Jul 31, 2024
@laura-l-amaral laura-l-amaral moved this from Backlog to Priorizado in Engenharia-SRE-UX Nov 27, 2024
@laura-l-amaral laura-l-amaral moved this from Priorizado to Em andamento in Engenharia-SRE-UX Nov 27, 2024
@isabelmeister isabelmeister moved this from Em andamento to Bloqueado in Engenharia-SRE-UX Dec 5, 2024
@isabelmeister isabelmeister moved this from Bloqueado to Em andamento in Engenharia-SRE-UX Dec 5, 2024
@isabelmeister
Copy link
Collaborator

PR - testes e melhoria de documentação
Testes do backend
Testes do Download/metadata

@isabelmeister
Copy link
Collaborator

isabelmeister commented Dec 19, 2024 •
edited
Loading

Verificado e conversado com a @laura-amaral sobre o não ver muito sentido em testar o basedosdados/core/base.py visto que:

  • muitas das funções são auxiliares, não tendo uma visão em testes unitários,
  • ser um arquivo mais baseado em configuração do projeto,
    fazendo mais sentido realizar:
  • o passo a passo
  • documentar o processo
  • o que colocar de input
  • o que não colocar
  • o que é necessário para que rode, de forma minuciosa e atenta aos detalhes.

@laura-l-amaral laura-l-amaral linked a pull request Dec 20, 2024 that will close this issue
Add minimal tests/ci #1740
Merged
@isabelmeister
Copy link
Collaborator

  • Code coverage above 80%
    Image

it's the minimum to be accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isabelmeister isabelmeister

Labels
infra New CLI version or infra related issues python
Projects
Engenharia-SRE-UX
Status: Em andamento
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add minimal tests/ci basedosdados/sdk
6 participants
@vncsna @jhonylucas74 @d116626 @JoaoCarabetta @gabriel-milan @isabelmeister