Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purify the recursive resolver #85

Open
barrucadu opened this issue Mar 21, 2022 · 0 comments
Open

Purify the recursive resolver #85

barrucadu opened this issue Mar 21, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@barrucadu
Copy link
Owner

The recursive resolver is awkward to test because it mixes network calls with business logic. So I just don't test it right now. I test the things it uses, but not it directly. This is a shame, as the recursive resolver is nontrivial.

Purifying it somehow - either making it return some state object and handling the network calls & iteration from a very small function outside it which can easily be eyeballed, or by passing in some "network handle" which can be mocked (ew) - would let me directly test it.

@barrucadu barrucadu added the enhancement New feature or request label Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant