Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn flow failing on the Page component #149

Open
AuroreM opened this issue Nov 26, 2017 · 1 comment
Open

yarn flow failing on the Page component #149

AuroreM opened this issue Nov 26, 2017 · 1 comment

Comments

@AuroreM
Copy link

AuroreM commented Nov 26, 2017

I've got an issue while running flow on a base generated project.
Indeed, noNavBar and noMargin props of the Page component are typed as required, but I don't think they should be.

If you agreed, I can do a Pull Request !
@Minishlink
Copy link
Contributor

Please do :)

@AuroreM AuroreM mentioned this issue Nov 26, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Minishlink @AuroreM