Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit:cfae966 broken on firefox #10

Open
micuat opened this issue Jul 13, 2020 · 5 comments
Open

commit:cfae966 broken on firefox #10

micuat opened this issue Jul 13, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@micuat
Copy link
Contributor

micuat commented Jul 13, 2020

does not load (window is empty) on firefox 78.0.2 (64-bit) on windows 10.

in console,

image

@micuat
Copy link
Contributor Author

micuat commented Jul 13, 2020

inspector:
image

@baku89
Copy link
Owner

baku89 commented Jul 14, 2020

It's because I used OffscreenCanvas for hit detection (which is for "Click to select a path in viewport" feature) and didn't implement its fallback for environments that don't support OffScreenCanvas yet. So I assume the newest version doesn't work in iOS Safari, too.

At present, I'd like to focus on supporting only Chrome since I've been also working for the Electron version. It might be better to show some alerts for such an environment ;)

@baku89
Copy link
Owner

baku89 commented Jul 14, 2020

Oh, I just noticed I don't need to use OffscreenCanvas because I didn't implement HitDetector (for detecting hovering item by cursor's position on the viewport) so that it runs in the Worker thread yet.

@baku89 baku89 added the enhancement New feature or request label Jul 14, 2020
@micuat
Copy link
Contributor Author

micuat commented Jul 19, 2020

commit:198294a works on firefox. should we close this issue...?

@baku89
Copy link
Owner

baku89 commented Jul 28, 2020

Look that way.
For cases like this, it might be better to show the alert message showing the recommended environment for viewers using mobile, IE, and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants