style(rubocop): lint

Author: an-lee

.rubocop.yml

@@ -2,7 +2,7 @@ require:
   - 'rubocop-rails'
 
 AllCops:
-  TargetRubyVersion: '2.7.0'
+  TargetRubyVersion: '2.7.1'
   Exclude:
     - 'bin/**/*'
     - 'db/**/*'
@@ -22,9 +22,6 @@ Metrics/ClassLength:
 Metrics/CyclomaticComplexity:
   Enabled: false
 
-Metrics/LineLength:
-  Enabled: false
-
 Metrics/MethodLength:
   Enabled: false
 
@@ -50,7 +47,7 @@ Style/NumericLiterals:
   Enabled: false
 
 Rails/SkipsModelValidations:
-  Whitelist: ['increment!', 'touch']
+  AllowedMethods: ['increment!', 'touch']
 
 Naming/PredicateName:
   Enabled: false
@@ -61,5 +58,161 @@ Rails/Output:
 Lint/UnderscorePrefixedVariableName:
   Enabled: false
 
+Lint/FormatParameterMismatch:
+  Enabled: false
+
 ApplicationController:
   Enabled: false
+
+Layout/LineLength:
+  Enabled: false
+
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+
+Lint/RaiseException:
+  Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
+
+Lint/DuplicateElsifCondition:
+  Enabled: true
+
+Style/ExponentialNotation: 
+  Enabled: true
+
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true
+
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+
+Style/RedundantRegexpEscape:
+  Enabled: true
+
+Style/SlicingWithRange:
+  Enabled: true
+
+Style/RedundantFetchBlock:
+  Enabled: true
+
+Style/AccessorGrouping:
+  Enabled: true
+
+Style/BisectedAttrAccessor:
+  Enabled: true
+
+Style/RedundantAssignment:
+  Enabled: true
+
+Style/ArrayCoercion:
+  Enabled: true
+
+Style/CaseLikeIf:
+  Enabled: true
+
+Style/HashAsLastArrayItem:
+  Enabled: true
+
+Style/HashLikeCase:
+  Enabled: true
+
+Style/RedundantFileExtensionInRequire:
+  Enabled: true
+
+Rails/ActiveRecordCallbacksOrder:
+  Enabled: true
+
+Rails/FindById:
+  Enabled: true
+
+Rails/Inquiry:
+  Enabled: true
+
+Rails/MailerName:
+  Enabled: true
+
+Rails/MatchRoute:
+  Enabled: true
+
+Rails/NegateInclude:
+  Enabled: true
+
+Rails/Pluck:
+  Enabled: true
+
+Rails/PluckId:
+  Enabled: true
+
+Rails/PluckInWhere:
+  Enabled: true
+
+Rails/RenderInline:
+  Enabled: true
+
+Rails/RenderPlainText:
+  Enabled: true
+
+Rails/ShortI18n:
+  Enabled: true
+
+Rails/WhereExists:
+  Enabled: true
+
+Lint/BinaryOperatorWithIdenticalOperands:
+  Enabled: true
+
+Lint/DuplicateRescueException:
+  Enabled: true
+
+Lint/EmptyConditionalBody:
+  Enabled: true
+
+Lint/FloatComparison:
+  Enabled: true
+
+Lint/MissingSuper:
+  Enabled: true
+
+Lint/OutOfRangeRegexpRef:
+  Enabled: true
+
+Lint/SelfAssignment:
+  Enabled: true
+
+Lint/TopLevelReturnWithArgument:
+  Enabled: true
+
+Lint/UnreachableLoop:
+  Enabled: true
+
+Style/ExplicitBlockArgument:
+  Enabled: true
+
+Style/GlobalStdStream:
+  Enabled: true
+
+Style/OptionalBooleanParameter:
+  Enabled: true
+
+Style/SingleArgumentDig:
+  Enabled: true
+
+Style/StringConcatenation:
+  Enabled: true

Gemfile

@@ -88,8 +88,8 @@ gem 'batch-loader'
 gem 'order_as_specified'
 
 # A performance dashboard for Postgres
-gem 'pg_query', '>= 0.9.0'
 gem 'pghero'
+gem 'pg_query', '>= 0.9.0'
 
 # deploy
 gem 'mina', require: false

Gemfile.lock

@@ -340,13 +340,13 @@ GEM
       mime-types (>= 1.16, < 4.0)
       netrc (~> 0.8)
     rexml (3.2.4)
-    rubocop (0.88.0)
+    rubocop (0.89.1)
       parallel (~> 1.10)
       parser (>= 2.7.1.1)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.7)
       rexml
-      rubocop-ast (>= 0.1.0, < 1.0)
+      rubocop-ast (>= 0.3.0, < 1.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
     rubocop-ast (0.3.0)

app/controllers/admin/base_controller.rb

@@ -31,6 +31,6 @@ def admin_sign_out
   end
 
   def from_graphql_introspection
-    Rails.env.development? && request.headers['Authorization'] == Rails.application.credentials.dig(:graphql_introspection_token)
+    Rails.env.development? && request.headers['Authorization'] == Rails.application.credentials[:graphql_introspection_token]
   end
 end

app/controllers/application_controller.rb

@@ -34,7 +34,7 @@ def user_sign_out
   end
 
   def from_graphql_introspection
-    Rails.env.development? && request.headers['Authorization'] == Rails.application.credentials.dig(:graphql_introspection_token)
+    Rails.env.development? && request.headers['Authorization'] == Rails.application.credentials[:graphql_introspection_token]
   end
 
   def base_props

app/models/mixin_group.rb

@@ -21,7 +21,7 @@
 #  index_mixin_groups_on_creator_id       (creator_id)
 #
 class MixinGroup < ApplicationRecord
-  belongs_to :creator, class_name: 'User', primary_key: :mixin_uuid, foreign_key: :creator_id, inverse_of: false
+  belongs_to :creator, class_name: 'User', primary_key: :mixin_uuid, inverse_of: false
 
   before_validation :set_attributes
   after_create :find_or_create_participants!

app/models/multisig_account.rb

@@ -21,7 +21,7 @@
 #  index_multisig_accounts_on_member_uuids  (member_uuids)
 #
 class MultisigAccount < ApplicationRecord
-  belongs_to :creator, class_name: 'User', foreign_key: :creator_id, inverse_of: false
+  belongs_to :creator, class_name: 'User', inverse_of: false
 
   has_many :multisig_account_members, dependent: :nullify
   has_many :members, through: :multisig_account_members, source: :user

app/models/multisig_payment.rb

@@ -28,9 +28,9 @@
 #  index_multisig_payments_on_trace_id             (trace_id) UNIQUE
 #
 class MultisigPayment < ApplicationRecord
-  belongs_to :creator, class_name: 'User', foreign_key: :creator_id, inverse_of: :created_payments
+  belongs_to :creator, class_name: 'User', inverse_of: :created_payments
   belongs_to :multisig_account
-  belongs_to :asset, primary_key: :asset_id, foreign_key: :asset_id, inverse_of: false
+  belongs_to :asset, primary_key: :asset_id, inverse_of: false
 
   before_validation :set_attributes, on: :create
 

app/models/multisig_transaction.rb

@@ -33,7 +33,7 @@ class MultisigTransaction < ApplicationRecord
 
   belongs_to :user
   belongs_to :multisig_account
-  belongs_to :asset, primary_key: :asset_id, foreign_key: :asset_id, inverse_of: false
+  belongs_to :asset, primary_key: :asset_id, inverse_of: false
 
   before_validation :set_attributes, on: :create
 

config/clock.rb

@@ -2,7 +2,7 @@
 
 # Initialize sidekiq
 require 'sidekiq'
-require_relative './initializers/sidekiq.rb'
+require_relative './initializers/sidekiq'
 def sidekiq_perform_async(worker_name)
   ::Sidekiq::Client.push('class' => worker_name, 'args' => [])
 end