Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyrillic is not supported #9799

Open
1 task done
plyaskin opened this issue May 14, 2024 · 13 comments
Open
1 task done

Cyrillic is not supported #9799

plyaskin opened this issue May 14, 2024 · 13 comments
Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working. Discussion When need discussion on some execution.

Comments

@plyaskin
Copy link

plyaskin commented May 14, 2024

Terms

  • Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected

v2.1.2

Issue Description

I can't create the category with a Russian name.
EN - Organization and storage of things
RU - Организация и хранение вещей

Creating products in Russian also does not work correctly (URLs).

Preconditions

When you create the new category with EN text it works, but Russian does not.

Steps to reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected Result

Russian text

Actual Result

When I change the language for text in Category
EN - Reloading page
RU - Screenshot
For Chinese the same - Undefined array key "zh_CN"

Screenshots

2024-05-14_23-58-46

No response

Additional context

No response

@plyaskin plyaskin added the Bug Something isn't working. label May 14, 2024
@plyaskin plyaskin changed the title The category name is not supported in Cyrillic Cyrillic is not supported May 14, 2024
@ashishkumar-webkul ashishkumar-webkul added the In Testing When PR in testing. label May 16, 2024
@ashishkumar-webkul
Copy link
Collaborator

Thank you so much for bringing the issue to our attention; we truly appreciate it.

Upon checking the master branch, we were unable to replicate any such exceptional errors. However, we did notice that the slug visible in the Russian locale appears to be a hyphen. Please refer to the video for a clearer understanding of the concern.

Video

Russian.mp4

For further discussion on this matter, we would like to discuss the issue to address your concerns comprehensively. We will reach out to you shortly to arrange a suitable time.

Additionally, I have investigated the issue in V2.1.2, and indeed, we encountered the exceptional error you described. I'm pleased to inform you that this issue has already been raised and fixed. The corresponding PR has been merged, and you can find more information in the following links for your reference:

Issue Link: #9612

PR Link: #9613

Please review the links above to address your concerns. Additionally, I've attached a video demonstrating the issue for your reference.

Issue Video

previous.mp4

@ashishkumar-webkul ashishkumar-webkul added Discussion When need discussion on some execution. and removed In Testing When PR in testing. labels May 16, 2024
@plyaskin
Copy link
Author

plyaskin commented May 16, 2024

Thank you for the reply.
You can find my problems here.
https://disk.yandex.ru/i/NHayFEYMG-FijA
https://disk.yandex.ru/i/flhgnOtk55tidA

Could you let me know how to update the application version to the latest (master)?

@ashishkumar-webkul
Copy link
Collaborator

@plyaskin

The issue to which you are referring in the video has already been fixed. However, upon checking your concern, we need to discuss the slug-related issue in the Category for different locales. We will discuss this and inform you accordingly.

issue fixed in following PR -> #9613

@jitendra-webkul
Copy link
Member

ALready fixed in the master

@plyaskin
Copy link
Author

@jitendra-webkul It is still there - the Cyrillic Slug is corrupted "website.com/-".

@jitendra-webkul
Copy link
Member

Will look into it

jitendra-webkul added a commit to jitendra-webkul/bagisto that referenced this issue May 22, 2024
@jitendra-webkul jitendra-webkul added the Bug Fixed When bug issue is fixed. label May 23, 2024
@jitendra-webkul
Copy link
Member

Issue has been fixed in PR #9832

@plyaskin
Copy link
Author

Hi @jitendra-webkul
I'm not sure that it should save Cyrillic or another language in the URL address, because some URLs will not opened in this case...
It will be better to save it in English.

@jitendra-webkul
Copy link
Member

You will still have the option to save in the English.

@plyaskin
Copy link
Author

But also customers will have errors with other languages... and a lot of reports to you.
Exclude the possibility of an error.

@jitendra-webkul
Copy link
Member

We have tested with all 19 available locales. If you encounter a specific case where it is not working, please share the details with us, and we will look into it.

@plyaskin
Copy link
Author

plyaskin commented May 23, 2024

Could you confirm if the URL address supports Hindi, Hebrew, Arabic or Cyrillic symbols and diacritics like č, ř, ž?
Did you try to open the product for 19 available locales in the browser with a localised slug?
I'm not sure that this URL will be opened and will not back an error like "The page not found"

jitendra-webkul added a commit to jitendra-webkul/bagisto that referenced this issue May 31, 2024
@jitendra-webkul
Copy link
Member

Tested with Hindi, Hebrew, Arabic, now it's working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working. Discussion When need discussion on some execution.
Projects
None yet
Development

No branches or pull requests

3 participants