Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category Filter -> Max Price Filter issue appearing. Decimal Value entry not appearing. #9588

Closed
1 task done
ashishkumar-webkul opened this issue Mar 13, 2024 · 4 comments
Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working. Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged.

Comments

@ashishkumar-webkul
Copy link
Collaborator

Terms

  • Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected

2.1.1

Issue Description

When we have created a product with decimal entry price eg. $200.99 or $250.50, and saving the product. We can see that the price filter is not showing the decimal entry of the maximum price.

Preconditions

  1. Admin must be logged in.
  2. Create any product with Price in Decimal.

Steps to reproduce

  1. Go to Admin -> Catalog -> Create a product -> Fill Price -> $250.50 or 200.99 -> Fill detail and Save Product.
  2. Go to shop front -> Select Category -> Check the price Filter.
  3. Check the maximum Price.

Expected Result

We should be able to see the product maximum price in the price filter.

Actual Result

Currently we can see that the price filter is not showing the decimal entries. Please check the video for reference.

Video

Price.mp4

Screenshots

Please check the screenshot here

Additional context

No response

@ashishkumar-webkul ashishkumar-webkul added the Bug Something isn't working. label Mar 13, 2024
amit-webkul added a commit to amit-webkul/bagisto that referenced this issue Mar 27, 2024
@amit-webkul amit-webkul added the Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. label Mar 27, 2024
@ashishkumar-webkul ashishkumar-webkul added Change Request if need any changes on PR and removed Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. labels Apr 2, 2024
@hussaincoder23
Copy link
Contributor

@ashishkumar-webkul , I have fixed issue check PR https://github.com/bagisto/bagisto/pull/9846

@ashishkumar-webkul
Copy link
Collaborator Author

@hussaincoder23,

Thank you so much for your contribution. We really appreciate your efforts.

We have checked your PR and found that some changes are needed. It seems there is still an issue in the PR. You can check the video attached to the PR for reference.

Kindly fix the issue.

Thank you so much.

@hussaincoder23
Copy link
Contributor

hussaincoder23 commented May 30, 2024

@ashishkumar-webkul i have updated PR according to your change request , i have added point value steps to low price filter too . Thanks for appreciation .
Check PR [https://github.com/bagisto/bagisto/pull/9846]

@ashishkumar-webkul
Copy link
Collaborator Author

@hussaincoder23

We have checked the PR and found that working fine. We need to check the coding standard as well hence we will update you accordingly on the PR.

Thanks for your efforts.

@devansh-webkul devansh-webkul added Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. and removed Change Request if need any changes on PR labels May 31, 2024
jitendra-webkul added a commit that referenced this issue May 31, 2024
…der-issue

Fixed max price filter slider issue #9588
@jitendra-webkul jitendra-webkul added the Bug Fixed When bug issue is fixed. label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working. Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged.
Projects
None yet
Development

No branches or pull requests

5 participants