- Windows versions of PixelFlasher are now signed (self-signed).

  Hopefully this would cut down on false positive virus / trojan alerts, but it should also get rid of Unrecognized app warnings.
  [PixelFlasher.crt](https://github.com/badabing2005/PixelFlasher/blob/main/PixelFlasher.crt) is the certificate, and [ca_badabing2005.crt](https://github.com/badabing2005/PixelFlasher/blob/main/ca_badabing2005.crt) is the root CA.
- Bugfix: #221 handle a corner case exception.

Author: badabing2005

.github/workflows/main.yml

@@ -89,12 +89,27 @@ jobs:
       - name: Build application
         run: .\build.bat
 
+      - name: List contents of dist directory
+        run: ls dist
+
+      - name: Sign Windows Executable
+        uses: skymatic/code-sign-action@v1
+        with:
+          certificate: '${{ secrets.CERTIFICATE }}'
+          password: '${{ secrets.CERT_PASSWORD }}'
+          certificatesha1: '${{ secrets.CERTHASH }}'
+          certificatename: '${{ secrets.CERTNAME }}'
+          description: 'PixelFlasher'
+          timestampUrl: 'http://timestamp.digicert.com'
+          folder: 'dist'
+          recursive: false
+
       - name: Get sha256
         run: |
           certutil -hashfile dist/PixelFlasher.exe SHA256 > dist/PixelFlasher.exe.sha256
           cat dist/PixelFlasher.exe.sha256
 
-      - name: List contents of dist directory
+      - name: List contents of dist directory again
         run: ls dist
 
       # Upload artifacts Windows
@@ -151,12 +166,27 @@ jobs:
       - name: Rename the file
         run: mv dist/PixelFlasher.exe dist/PixelFlasher_Win_2019.exe
 
+      - name: List contents of dist directory
+        run: ls dist
+
+      - name: Sign Windows Executable
+        uses: skymatic/code-sign-action@v1
+        with:
+          certificate: '${{ secrets.CERTIFICATE }}'
+          password: '${{ secrets.CERT_PASSWORD }}'
+          certificatesha1: '${{ secrets.CERTHASH }}'
+          certificatename: '${{ secrets.CERTNAME }}'
+          description: 'PixelFlasher'
+          timestampUrl: 'http://timestamp.digicert.com'
+          folder: 'dist'
+          recursive: false
+
       - name: Get sha256
         run: |
           certutil -hashfile dist/PixelFlasher_Win_2019.exe SHA256 > dist/PixelFlasher_Win_2019.exe.sha256
           cat dist/PixelFlasher_Win_2019.exe.sha256
 
-      - name: List contents of dist directory
+      - name: List contents of dist directory again
         run: ls dist
 
       # Upload artifacts Windows 2019

.github/workflows/windows_2019.yml

@@ -89,12 +89,27 @@ jobs:
       - name: Rename the file
         run: mv dist/PixelFlasher.exe dist/PixelFlasher_Win_2019.exe
 
+      - name: List contents of dist directory
+        run: ls dist
+
+      - name: Sign Windows Executable
+        uses: skymatic/code-sign-action@v1
+        with:
+          certificate: '${{ secrets.CERTIFICATE }}'
+          password: '${{ secrets.CERT_PASSWORD }}'
+          certificatesha1: '${{ secrets.CERTHASH }}'
+          certificatename: '${{ secrets.CERTNAME }}'
+          description: 'PixelFlasher'
+          timestampUrl: 'http://timestamp.digicert.com'
+          folder: 'dist'
+          recursive: false
+
       - name: Get sha256
         run: |
           certutil -hashfile dist/PixelFlasher_Win_2019.exe SHA256 > dist/PixelFlasher_Win_2019.exe.sha256
           cat dist/PixelFlasher_Win_2019.exe.sha256
 
-      - name: List contents of dist directory
+      - name: List contents of dist directory again
         run: ls dist
 
       # Upload artifacts Windows to Actions

.github/workflows/windows_2022.yml

@@ -86,15 +86,30 @@ jobs:
       - name: Build application
         run: .\build.bat
 
+      - name: List contents of dist directory
+        run: ls dist
+
+      - name: Sign Windows Executable
+        uses: skymatic/code-sign-action@v1
+        with:
+          certificate: '${{ secrets.CERTIFICATE }}'
+          password: '${{ secrets.CERT_PASSWORD }}'
+          certificatesha1: '${{ secrets.CERTHASH }}'
+          certificatename: '${{ secrets.CERTNAME }}'
+          description: 'PixelFlasher'
+          timestampUrl: 'http://timestamp.digicert.com'
+          folder: 'dist'
+          recursive: false
+
       - name: Get sha256
         run: |
           certutil -hashfile dist/PixelFlasher.exe SHA256 > dist/PixelFlasher.exe.sha256
           cat dist/PixelFlasher.exe.sha256
 
-      - name: List contents of dist directory
+      - name: List contents of dist directory again
         run: ls dist
 
-      # Upload artifacts Windows to Actions
+          # Upload artifacts Windows to Actions
       - name: Upload Windows Artifact
         if: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' }} # Only run this step when running in GitHub Actions
         uses: actions/upload-artifact@v4

PixelFlasher.crt

@@ -0,0 +1,19 @@
+-----BEGIN CERTIFICATE-----
+MIIDKzCCAhOgAwIBAgIUYIRGzv8e03vx107/JWQp/MI+GwAwDQYJKoZIhvcNAQEL
+BQAwFzEVMBMGA1UEAwwMQmFkYWJpbmcyMDA1MB4XDTI0MDcxNDEzMjMwMVoXDTI1
+MTEyNjEzMjMwMVowFzEVMBMGA1UEAwwMUGl4ZWxGbGFzaGVyMIIBIjANBgkqhkiG
+9w0BAQEFAAOCAQ8AMIIBCgKCAQEAmxbQHvRwgER0TJDEtPurapZS5/r7pCudJNqr
+kv54C+FaVK0TVnLefjfwxeR1ILu6kjis8/OMWAE5lvoLlXrnXrC3buipiESwZE4q
+DtA8aUS0kKn6DbJaYcNrsYSglq3xNJ1SskX6uH5R3WHeJ0PJJcXystnE1e+GOsBh
+qbJOoJy1VpacHnVXg1tMM8Un92X1aYDMj6HOBNhRQicHkhWHx+7WvOHqDM9j6wpR
+39dyov3Hd+R0cs+zAaXKdBLCBqD3N9/UAKd+S/b+BA08tsdmq+ud1EG3oZYLa7Ze
+f9MhwlW/ba3MRHBnqylV1dmtYFFzsCjOCNIQeHFic7sjNn9NawIDAQABo28wbTAf
+BgNVHSMEGDAWgBTOCWAMovsa2+SS21Sog9rk7liIWzAJBgNVHRMEAjAAMAsGA1Ud
+DwQEAwIHgDATBgNVHSUEDDAKBggrBgEFBQcDAzAdBgNVHQ4EFgQUzDaSWtxu3qIh
+DRSnUMONx2aX2XUwDQYJKoZIhvcNAQELBQADggEBAClrh6pMNSmcGERatopjH6sQ
+32E6nEZuQkCX+x48JoaDUWSHVfCteCy4KraJ/ina3UyLWXNW6qvuYUraY98KI+eY
+DzNzRETY3g/cRMxvswbm81ZPki282J9LxlunFaOvwQnbtLJsIg+8Tj/aD/YBvs2h
+E06+/VzoDZ8aQaIth8TPZ1e3HrzDn4oNsG0CnfnZ3QtdcpSKgi/sFdMui8NAmIjd
+zsCoRfYw5hPeZem11KJ2+dv3bDIC0AKy6Opd0YE164lHUGL46Y15uzm536rHjiZA
+sQArmuwWNAKs0gvYYGEBoYCgkPOmh8LUtCrNCKC3dAN7neUmlwjpsVic1K8RbFE=
+-----END CERTIFICATE-----

build-on-mac.spec

@@ -28,6 +28,6 @@ exe = EXE(pyz,
           icon='images/icon-dark-256.icns')
 app = BUNDLE(exe,
              name='PixelFlasher.app',
-             version='7.1.0.0',
+             version='7.1.1.0',
              icon='./images/icon-dark-256.icns',
              bundle_identifier='com.badabing.pixelflasher')

build.sh

@@ -31,7 +31,7 @@
 # <https://www.gnu.org/licenses/>.
 
 rm -rf build dist
-VERSION=7.1.0.0
+VERSION=7.1.1.0
 NAME="PixelFlasher"
 DIST_NAME="PixelFlasher"
 

ca_badabing2005.crt

@@ -0,0 +1,19 @@
+-----BEGIN CERTIFICATE-----
+MIIDDTCCAfWgAwIBAgIUG8IsWabGyCjhtULTwryYRiAnw5UwDQYJKoZIhvcNAQEL
+BQAwFzEVMBMGA1UEAwwMQmFkYWJpbmcyMDA1MB4XDTI0MDcxNDEzMjE0OVoXDTI3
+MDUwNDEzMjE0OVowFzEVMBMGA1UEAwwMQmFkYWJpbmcyMDA1MIIBIjANBgkqhkiG
+9w0BAQEFAAOCAQ8AMIIBCgKCAQEAxLfwi9WCL31RUrkUsr5EC4Icbce7VwFMkAi9
+j5jAelBjOaifjm3IkpE36ysDgN/BZwuwHOOgZF+30KWETm2hTtJlgL4aO6T+JbqA
+l0XeWTHz9o9KMhcrXMitBE2QKf2ewfgbpQ+S6p7tk9yywUFr4R1K4gexyhQKpogm
+GmKbksG7XJQoVeVj3mLjtpQdeHhNuGghmmKiZMx+4HTH5p/jdF53ikCWiaoMK+oN
+0LjFORXrFfXOhuv1gWr1HbD2iXb9EKwddUTF0fl20upyv5M3zlamfREqnCz5HXxJ
+uGNdiDk3Gs7Revd6EgP+hIIQrLv2dwwBowPPA53X+0wvXPa/mwIDAQABo1EwTzAM
+BgNVHRMEBTADAQH/MAsGA1UdDwQEAwIChDATBgNVHSUEDDAKBggrBgEFBQcDAzAd
+BgNVHQ4EFgQUzglgDKL7GtvkkttUqIPa5O5YiFswDQYJKoZIhvcNAQELBQADggEB
+AEkwQhlOURaXxdxDiQCgk4Y6JKejY7E8cmdoZJiEZ6DxmMvqie0j32dI5ttii8og
+imgR6MXVtjJgHdMaSnUzzvg1ePmMURQimKjaEWIz+k18Hrcj1TyUBp6DFEbSaKfj
+0xmmSfkP3TlSd2MSV+tQHWuv4csdFjmv+UuhWOvBpRwEvmb6V+IX+i7A1ohAxnFO
+LX0qzVxs+33/0iBaRxXl7lZ6VYh+jfCZ6CrYEut6dR+TwIDA0/0Z4/4Hg6MkTuzM
+N5AzycYrvP/lEM4g6MhCpasH7MT2d/i0MMQQfAA1cPYyaASjDrsYc+l2rDyH7tuU
+H7kne0e2aWC9TY9hvA9mgMI=
+-----END CERTIFICATE-----

constants.py

@@ -34,7 +34,7 @@
 
 APPNAME = 'PixelFlasher'
 CONFIG_FILE_NAME = 'PixelFlasher.json'
-VERSION = '7.1.0.0'
+VERSION = '7.1.1.0'
 SDKVERSION = '33.0.3'
 MAIN_WIDTH = 1400
 MAIN_HEIGHT = 1040

modules.py

@@ -354,7 +354,7 @@ def identify_sdk_version(self):
                             if parse(sdkver) < parse(SDKVERSION) or (sdkver in ('34.0.0', '34.0.1', '34.0.2', '34.0.3', '34.0.4')):
                                 print(f"\n❌ {datetime.now():%Y-%m-%d %H:%M:%S} ERROR: Detected old or problematic Android Platform Tools version {sdk_version}")
                                 # confirm if you want to use older version
-                                dlg = wx.MessageDialog(None, f"You have an old or problematic Android platform Tools version {sdk_version}\nYou are strongly advised to update to the latest known good version to avoid any issues.\n(Android Platform-Tools version 33.0.3 is known to be good).\n\nAre you sure want to continue?",'Bad Android Platform Tools',wx.YES_NO | wx.NO_DEFAULT | wx.ICON_EXCLAMATION)
+                                dlg = wx.MessageDialog(None, f"You have an old or problematic Android platform Tools version {sdk_version}\nYou are strongly advised to                if (boot.is_init_boot or (device.hardware is not None and device.hardware in KNOWN_INIT_BOOT_DEVICES)) and boot.patch_method not in ['kernelsu', 'apatch']:hod not in ['kernelsu', 'apatch']:hod not in ['kernelsu', 'apatch']:re want to continue?",'Bad Android Platform Tools',wx.YES_NO | wx.NO_DEFAULT | wx.ICON_EXCLAMATION)
                                 result = dlg.ShowModal()
                                 puml(f"#red:Selected Platform Tools;\nnote left: {self.config.platform_tools_path}\nnote right:ERROR: Detected old or problematic Android Platform Tools version {sdk_version}\n")
                                 if result == wx.ID_YES:
@@ -4231,7 +4231,7 @@ def apply_patch_if_needed():
                     # flash the patch
                     flash = "flash"
 
-                if (boot.is_init_boot or device.hardware in KNOWN_INIT_BOOT_DEVICES) and boot.patch_method not in ['kernelsu', 'apatch']:
+                if (boot.is_init_boot or (device.hardware is not None and device.hardware in KNOWN_INIT_BOOT_DEVICES)) and boot.patch_method not in ['kernelsu', 'apatch']:
                     print("Flashing patched init_boot ...")
                     theCmd = f"\"{get_fastboot()}\" -s {device_id} {fastboot_options} {flash} init_boot \"{boot.boot_path}\"\n"
                     is_init_boot = True

windows-metadata.yaml

@@ -1,6 +1,6 @@
 # https://github.com/DudeNr33/pyinstaller-versionfile
 # create-version-file windows-metadata.yaml --outfile windows-version-info.txt
-Version: 7.1.0.0
+Version: 7.1.1.0
 FileDescription: PixelFlasher
 InternalName: PixelFlasher
 OriginalFilename: PixelFlasher.exe