Dropping mocha in favour of rspec-mocks #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this awesome contribution, I'm pretty impressed. Were you able to automate this a bit ? or is this hand-crafted only ? |
|
Thanks @kpumuk for the contribution. As discussed in the issue #803 and documented in the PR #955, and unless people express their voice against it, we're in the process of moving toward a community-based governance for the project. Under that new (and simple) policy, anyone submitting a non-trivial contribution can request to become a committer and help maintain and improve backup. I believe this contribution is substantial and hence would like to know if you'd be interested in becoming a committer of the project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop Mocha stub library to use the built-in RSpec mocks instead.
Closes #823