Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake target naming is likely to conflict as a sub project. #23

Open
OmniBlade opened this issue Oct 18, 2022 · 1 comment
Open

CMake target naming is likely to conflict as a sub project. #23

OmniBlade opened this issue Oct 18, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@OmniBlade
Copy link

Target names such as compat, client and handler are fairly common names developers might choose for their own targets and thus using the backtrace fork is likely to cause issues vs other forks providing the CMake build system where the targets are normally prefixed "crashpad_".

@KrzaQ KrzaQ self-assigned this Oct 19, 2022
@KrzaQ KrzaQ added the bug Something isn't working label Oct 19, 2022
@KrzaQ
Copy link
Contributor

KrzaQ commented Oct 19, 2022

It's a very good point. Thanks for bringing that up. I'm on it.

@KrzaQ KrzaQ removed their assignment Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants