From c97ed0a28199173d04f717d3573ad6c00539094a Mon Sep 17 00:00:00 2001
From: Konrad Dysput <konrad.dysput@gmail.com>
Date: Thu, 9 May 2024 13:39:42 +0200
Subject: [PATCH] Use obsolete attribute to display warning (#213)

---
 Runtime/Attributes.meta                          |  8 --------
 Runtime/Attributes/NotSupportedAttribute.cs      |  9 ---------
 Runtime/Attributes/NotSupportedAttribute.cs.meta | 11 -----------
 Runtime/Model/BacktraceConfiguration.cs          | 15 +++++++--------
 Tests/Runtime/BacktraceClientTests.cs            |  3 ++-
 5 files changed, 9 insertions(+), 37 deletions(-)
 delete mode 100644 Runtime/Attributes.meta
 delete mode 100644 Runtime/Attributes/NotSupportedAttribute.cs
 delete mode 100644 Runtime/Attributes/NotSupportedAttribute.cs.meta

diff --git a/Runtime/Attributes.meta b/Runtime/Attributes.meta
deleted file mode 100644
index 13cf0724..00000000
--- a/Runtime/Attributes.meta
+++ /dev/null
@@ -1,8 +0,0 @@
-fileFormatVersion: 2
-guid: f354e77c1d37ece40ac522611a2406e4
-folderAsset: yes
-DefaultImporter:
-  externalObjects: {}
-  userData: 
-  assetBundleName: 
-  assetBundleVariant: 
diff --git a/Runtime/Attributes/NotSupportedAttribute.cs b/Runtime/Attributes/NotSupportedAttribute.cs
deleted file mode 100644
index 3610d927..00000000
--- a/Runtime/Attributes/NotSupportedAttribute.cs
+++ /dev/null
@@ -1,9 +0,0 @@
-using System;
-
-namespace Backtrace.Unity.Attributes
-{
-    [Obsolete("Not supported")]
-    public class NotSupportedAttribute : Attribute
-    {
-    }
-}
\ No newline at end of file
diff --git a/Runtime/Attributes/NotSupportedAttribute.cs.meta b/Runtime/Attributes/NotSupportedAttribute.cs.meta
deleted file mode 100644
index 9bb0e2fa..00000000
--- a/Runtime/Attributes/NotSupportedAttribute.cs.meta
+++ /dev/null
@@ -1,11 +0,0 @@
-fileFormatVersion: 2
-guid: 502694db60fa0574c9a55a5c737572bf
-MonoImporter:
-  externalObjects: {}
-  serializedVersion: 2
-  defaultReferences: []
-  executionOrder: 0
-  icon: {instanceID: 0}
-  userData: 
-  assetBundleName: 
-  assetBundleVariant: 
diff --git a/Runtime/Model/BacktraceConfiguration.cs b/Runtime/Model/BacktraceConfiguration.cs
index 4cbe0543..5db954ee 100644
--- a/Runtime/Model/BacktraceConfiguration.cs
+++ b/Runtime/Model/BacktraceConfiguration.cs
@@ -1,5 +1,4 @@
-using Backtrace.Unity.Attributes;
-using Backtrace.Unity.Common;
+using Backtrace.Unity.Common;
 using Backtrace.Unity.Model.Breadcrumbs;
 using Backtrace.Unity.Services;
 using Backtrace.Unity.Types;
@@ -140,7 +139,7 @@ public class BacktraceConfiguration : ScriptableObject
         /// <summary>  
         /// Capture native crashes.
         /// </summary>
-        [NotSupported]
+        [Obsolete("Not supported")]
 #endif
         public bool CaptureNativeCrashes = true;
 
@@ -150,7 +149,7 @@ public class BacktraceConfiguration : ScriptableObject
 #if UNITY_ANDROID || UNITY_IOS || UNITY_STANDALONE_WIN
         [Tooltip("Capture ANR events - Application not responding")]
 #else
-        [NotSupported]
+        [Obsolete("Not supported")]
 #endif
         public bool HandleANR = true;
 
@@ -161,7 +160,7 @@ public class BacktraceConfiguration : ScriptableObject
 #if UNITY_ANDROID || UNITY_IOS || UNITY_STANDALONE_WIN
         [Tooltip("ANR watchdog timeout")]
 #else
-        [NotSupported]
+        [Obsolete("Not supported")]
 #endif
         public int AnrWatchdogTimeout = DefaultAnrWatchdogTimeout;
 
@@ -171,7 +170,7 @@ public class BacktraceConfiguration : ScriptableObject
 #if UNITY_ANDROID || UNITY_IOS
         [Tooltip("Send Out of Memory exceptions to Backtrace")]
 #else
-        [NotSupported]
+        [Obsolete("Not supported")]
 #endif
         public bool OomReports = false;
 
@@ -181,7 +180,7 @@ public class BacktraceConfiguration : ScriptableObject
 #if UNITY_2019_2_OR_NEWER && (UNITY_ANDROID || UNITY_IOS)
         [Tooltip("Enable client-side unwinding.")]
 #else
-        [NotSupported]
+        [Obsolete("Not supported")]
 #endif
         public bool ClientSideUnwinding = false;
 
@@ -192,7 +191,7 @@ public class BacktraceConfiguration : ScriptableObject
 #if UNITY_2019_2_OR_NEWER && UNITY_ANDROID
         [Tooltip("Symbols upload token required to upload symbols to Backtrace")]
 #else
-        [NotSupported]
+        [Obsolete("Not supported")]
 #endif
         public string SymbolsUploadToken = string.Empty;
 
diff --git a/Tests/Runtime/BacktraceClientTests.cs b/Tests/Runtime/BacktraceClientTests.cs
index 983419c9..a152081d 100644
--- a/Tests/Runtime/BacktraceClientTests.cs
+++ b/Tests/Runtime/BacktraceClientTests.cs
@@ -19,13 +19,14 @@ public void Setup()
         }
 
         [UnityTest]
+        [Obsolete]
         public IEnumerator TestClientConfigurationOptions_ValidConfigurationWithAllOptions_AllowsToUseNotSupportedOptions()
         {
             var clientConfiguration = GetValidClientConfiguration();
-            clientConfiguration.OomReports = false;
             clientConfiguration.HandleANR = false;
             clientConfiguration.AnrWatchdogTimeout = 0;
             clientConfiguration.CaptureNativeCrashes = false;
+            clientConfiguration.OomReports = false;
             clientConfiguration.ClientSideUnwinding = false;
             clientConfiguration.SymbolsUploadToken = string.Empty;
             BacktraceClient.Configuration = clientConfiguration;