-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Bug Report: Missing React dependencies #24674
Labels
bug
Something isn't working
Comments
Yep 🙏 Thanks for creating the issue. All the templates are in here: https://github.com/backstage/backstage/tree/master/packages/cli/templates, so I think we just need to update the |
BethGriggs
added a commit
to BethGriggs/backstage
that referenced
this issue
Jun 5, 2024
…lates Fixes: backstage#24674 Signed-off-by: Beth Griggs <[email protected]>
5 tasks
BethGriggs
added a commit
to BethGriggs/backstage
that referenced
this issue
Jun 5, 2024
…lates Fixes: backstage#24674 Signed-off-by: Beth Griggs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
📜 Description
I was following the guidelines in the community-plugins repo, then I found that after creating a new frontend plugin with
yarn new
(actuallybackstage-cli new --scope @backstage-community
) inside my workspace, the command produced a package.json for the plugin with noreact
,react-dom
andreact-router-dom
dependencies listed. Runningyarn start
right after the plugin was created displayed a webpack error complaining about these missing dependencies.👍 Expected behavior
Other plugins that have been already migrated to the new community-plugins repo have these peerDependencies and devDependencies:
Probably these dependencies should be been added automatically to new frontend plugins are created.
👎 Actual Behavior with Screenshots
No
react
,react-dom
andreact-router-dom
dependencies are available after creating a new frontend plugin.👟 Reproduction steps
📃 Provide the context for the Bug.
No response
🖥️ Your Environment
OS: Darwin 23.4.0 - darwin/arm64
node: v18.18.2
yarn: 3.2.3
cli: 0.26.4 (installed)
backstage: 1.26.0
Dependencies:
@backstage/app-defaults 1.5.4
@backstage/backend-app-api 0.7.2
@backstage/backend-common 0.21.7
@backstage/backend-dev-utils 0.1.4
@backstage/backend-plugin-api 0.6.17
@backstage/backend-tasks 0.5.22
@backstage/catalog-client 1.6.4
@backstage/catalog-model 1.4.5
@backstage/cli-common 0.1.13
@backstage/cli-node 0.2.5
@backstage/cli 0.26.4
@backstage/config-loader 1.8.0
@backstage/config 1.2.0
@backstage/core-app-api 1.12.4
@backstage/core-components 0.14.6
@backstage/core-plugin-api 1.9.2
@backstage/dev-utils 1.0.31
@backstage/e2e-test-utils 0.1.1
@backstage/errors 1.2.4
@backstage/eslint-plugin 0.1.7
@backstage/frontend-plugin-api 0.6.4
@backstage/integration-aws-node 0.1.12
@backstage/integration-react 1.1.26
@backstage/integration 1.10.0
@backstage/plugin-auth-node 0.4.12
@backstage/plugin-catalog-common 1.0.22
@backstage/plugin-catalog-react 1.11.3
@backstage/plugin-permission-common 0.7.13
@backstage/plugin-permission-node 0.7.28
@backstage/plugin-permission-react 0.4.22
@backstage/plugin-search-common 1.2.11
@backstage/release-manifests 0.0.11
@backstage/repo-tools 0.8.0
@backstage/test-utils 1.5.4
@backstage/theme 0.5.3
@backstage/types 1.1.1
@backstage/version-bridge 1.0.8
👀 Have you spent some time to check if this bug has been raised before?
🏢 Have you read the Code of Conduct?
Are you willing to submit PR?
Yes I am willing to submit a PR!
The text was updated successfully, but these errors were encountered: