Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONGOING] Keep CKEditor 5 up to date (preferably with each minor release, unless it is a security-related update) #6481

Open
3 tasks
klonos opened this issue Apr 27, 2024 · 4 comments · May be fixed by backdrop/backdrop#4726

Comments

@klonos
Copy link
Member

klonos commented Apr 27, 2024

It would be nice to be updating to the latest release regularly (I am proposing with each minor release - we could do it in the 2 weeks between feature freeze and final release). ...if we don't keep up and we are several versions behind, then if a security release comes out we risk rushing to release the secure version, which might be introducing breaking changes, and we won't have enough time to test/adjust/fix things.

We are currently shipping core with v5, build 40.2.0. A few 41.x builds have been released since:

https://ckeditor.com/blog/categories/releases highlights the main improvements with new releases:

More resources related to releases

@quicksketch
Copy link
Member

PR at backdrop/backdrop#4726 updates us to 41.3.1.

I couldn't find any substantial changes that affect Backdrop's CKEditor installation. Some notes about new features and how they (don't) affect us:

  • List plugin is deprecated and DocumentList is now the only supported list plug. We are already using DocumentList
  • New Dialog UI Backdrop provides its own dialogs and does not use any CKEditor plugins that use dialogs.
  • Multi-level LIsts plugin This is a premium-only feature and not available in Backdrop
  • New Case Change Plugin We could decide to include this plugin if we think it is useful.

So seems like a straight-forward update process. I followed the UPGRADING.md file and there doesn't seem to be any issues in my testing.

@quicksketch quicksketch added this to the 1.28.0 milestone May 2, 2024
@indigoxela
Copy link
Member

New Dialog UI

Haven't had a chance to take a closer look, but would this help us with notifications? That's still pending. We're using an alert at one place and other messages are simply missing (file upload stuff).

I don't think, this has to be part of 1.28. I guess, we can update CKE any time we need. Especially, if the changes are minimal, anyway.

@klonos
Copy link
Member Author

klonos commented May 2, 2024

New Case Change Plugin We could decide to include this plugin if we think it is useful.

Yeah, I like that one. It helps with the styling of headings + sometimes people copy/paste text from other sources where others have typed everything in all-caps (a habit for some on mobile devices). That feature allows fixing that with a couple of clicks.

...other features like the following also seem useful and pretty standard (content editors expect to have those available):

  • import from Word
  • export to Word/PDF
  • Math Equations (.edu site content editors would appreciate that OOTB)
  • Find and replace
  • Table of contents
  • Font family (would help in our documentation site when formatting code with monospace for example)
    ...if these aren't premium of course.

@quicksketch
Copy link
Member

I don't think this would be a good idea to shove into 1.28.0 (today). Let's target this for 1.28.1, even though it's less-than-ideal that it will be in a bug fix release.

@quicksketch quicksketch modified the milestones: 1.28.0, 1.28.1 May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants