Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Graph image upload #18

Open
ghost opened this issue Jul 2, 2018 · 4 comments · May be fixed by #23
Open

Open Graph image upload #18

ghost opened this issue Jul 2, 2018 · 4 comments · May be fixed by #23
Assignees
Labels
enhancement need more votes Need more votes if this feature really needed more than to one people

Comments

@ghost
Copy link

ghost commented Jul 2, 2018

I've found that the image I want to use for the Open Graph meta tag is one I've already uploaded to the node, so I have to upload the same image twice (once for the node content, and one for the meta tag).

I'd like to therefore request the ability to either upload a new image, or link to an existing image. The easiest way to do this would be to allow pasting in a URL to an image (I could then copy & paste it from the node).

@ghost ghost added the enhancement label Jul 2, 2018
@findlabnet
Copy link
Member

Thank you, TBD.

@findlabnet findlabnet self-assigned this Jul 3, 2018
@findlabnet findlabnet added the need more votes Need more votes if this feature really needed more than to one people label Feb 14, 2019
@indigoxela
Copy link
Member

@findlabnet I'd also love to see this feature in SEO Meta Tags, but actually I belief, there's a way easier approach: enable the image browser in every "managed_file" form item.

Three of these managed_file items exist. Adding '#browser_view' => 'image_library', does the trick. So the addition of tree lines of code would solve the problem.

Wonder, why this hasn't been considered yet. Any technical concerns?

I could provide a PR, if that's OK for you.

@findlabnet
Copy link
Member

...if that's OK for you.

With pleasure. Just not enough free time and not too many requests for it.

@indigoxela
Copy link
Member

indigoxela commented Aug 30, 2022

Well, did I say "a three-liner"? Nope... 😀

Here's a PR that partly provides what I described, but... for the life of mine, I can't get this working with the multi-step forms (for front page, views and tags). The previous value simply isn't available anymore in the step, but we'd need these for proper file usage handling. Even in the database it's already gone when we reach the "validate" function. #23

The PR does work with the default settings form and with node forms, though.

Another finding: as the file usage is handled currently, the usage is always increased (even when just saving the form), but never decreased. (That explains why there are so many file usages for my user on a life site - caused me some head scratching.)

I wonder, if someone comes up with a smart idea for the multi-step forms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement need more votes Need more votes if this feature really needed more than to one people
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants