Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate Leaflet 1.9 #6

Closed
indigoxela opened this issue Sep 22, 2022 · 3 comments · Fixed by #9
Closed

Evaluate Leaflet 1.9 #6

indigoxela opened this issue Sep 22, 2022 · 3 comments · Fixed by #9

Comments

@indigoxela
Copy link
Member

A new version just came out - is the widget compatible?

https://github.com/Leaflet/Leaflet/releases/tag/v1.9.0
@indigoxela
Copy link
Member Author

It might be that Leaflet.draw won't be compatible with the next 2.0 anymore, as we now have a deprecation warning. See backdrop-contrib/leaflet#31 (comment)

Also keep in mind that the Leaflet team considers dropping support for that library, although it's the third in their list of "Popular repositories". That would mean a complete rewrite with a different library, though.
Leaflet/Leaflet.draw#1041

Remembering the effort it took to move from the Leaflet.widget library, when porting from D7, that might block an upgrade to Leaflet 2.0 for a while.

@indigoxela
Copy link
Member Author

Looks like 1.9.2 is the last version we can use, see Leaflet/Leaflet.draw#1041

@indigoxela
Copy link
Member Author

Or maybe a workaround?

indigoxela added a commit that referenced this issue Oct 10, 2022
@indigoxela
Issue #6: Add draw compatibility for recent Leaflet version
0e7b8fa
@indigoxela indigoxela mentioned this issue Oct 10, 2022
Merged
indigoxela added a commit that referenced this issue Oct 10, 2022
@indigoxela
Issue #6: Add draw compatibility for recent Leaflet version (#9)
544f70d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #6: Add draw compatibility for recent Leaflet version backdrop-contrib/leaflet_widget
1 participant
@indigoxela