Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit Pipfile.lock to the repo? #807

Open
inducer opened this issue Apr 17, 2024 · 4 comments
Open

Commit Pipfile.lock to the repo? #807

inducer opened this issue Apr 17, 2024 · 4 comments
Labels
help wanted Issues where maintainers could use assistance from others third party Relies on or blocked by a third party (dependency, vendor, platform, etc.)

Comments

@inducer
Copy link

inducer commented Apr 17, 2024

At least as far as I am aware, it's a best practice to commit the lock file generated by pipenv to the repository, to ensure that users get the same deterministic combination of packages that was tested during development.

@cdubz
Copy link
Member

cdubz commented Apr 20, 2024

There is some history here dealing with package locks not being compatible between architectures. I would reference the issue but on mobile right now.

Anyway it’s worth investigating if the situation is any different now. A few years back there was just no way to have a Pipfile cover multiple architectures. Maybe that has changed? Or maybe other tools have cropped up that can do this?

@cdubz cdubz added help wanted Issues where maintainers could use assistance from others third party Relies on or blocked by a third party (dependency, vendor, platform, etc.) labels Apr 20, 2024
@inducer
Copy link
Author

inducer commented Apr 21, 2024

I'm not sure about pipenv, but I know poetry is capable. It keeps a list of all wheels of a version (i.e. for all available architectures) in its lockfile and, seemingly, is able to choose between them at install time.

@cdubz
Copy link
Member

cdubz commented Apr 21, 2024

Definitely worth a look. Poetry wasn’t a thing back when I started this project. Switching out will be a bit of a chore but shouldn’t be crazy.

@cdubz
Copy link
Member

cdubz commented May 3, 2024

Relatedly just had to commit 6ae01d6 after discovering an issue with a new major release of a dependency 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues where maintainers could use assistance from others third party Relies on or blocked by a third party (dependency, vendor, platform, etc.)
Projects
None yet
Development

No branches or pull requests

2 participants