-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit Pipfile.lock
to the repo?
#807
Comments
There is some history here dealing with package locks not being compatible between architectures. I would reference the issue but on mobile right now. Anyway it’s worth investigating if the situation is any different now. A few years back there was just no way to have a Pipfile cover multiple architectures. Maybe that has changed? Or maybe other tools have cropped up that can do this? |
I'm not sure about pipenv, but I know poetry is capable. It keeps a list of all wheels of a version (i.e. for all available architectures) in its lockfile and, seemingly, is able to choose between them at install time. |
Definitely worth a look. Poetry wasn’t a thing back when I started this project. Switching out will be a bit of a chore but shouldn’t be crazy. |
Relatedly just had to commit 6ae01d6 after discovering an issue with a new major release of a dependency 🙃 |
At least as far as I am aware, it's a best practice to commit the lock file generated by
pipenv
to the repository, to ensure that users get the same deterministic combination of packages that was tested during development.The text was updated successfully, but these errors were encountered: