Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neil version patch: Improve SNAPSHOT version handling #145

Open
rads opened this issue Jan 21, 2023 · 0 comments
Open

neil version patch: Improve SNAPSHOT version handling #145

rads opened this issue Jan 21, 2023 · 0 comments

Comments

@rads
Copy link
Collaborator

rads commented Jan 21, 2023

When using neil version patch with versions ending with -SNAPSHOT, the version should have its suffix removed but not incremented. It's useful to set the :neil :project :version to a snapshot to make it obvious that the current build is a pre-release version until the final patch version is released.

Example use case:

$ bbin install io.github.babashka/bbin --latest-sha --as bbin-dev
{:coords
 #:git{:url "https://github.com/babashka/bbin.git",
       :sha "5a1076e589724e52071d3ec9ce8ea1627ebcfe8e"},
 :lib io.github.babashka/bbin}

$ bbin --version
bbin 0.1.8

$ bbin-dev --version
bbin 0.1.9-SNAPSHOT

Current behavior:

$ cat deps.edn
{:aliases {:neil {:project {:version "0.0.1-SNAPSHOT"}}}}

$ neil version patch
v0.0.2

Expected behavior:

$ cat deps.edn
{:aliases {:neil {:project {:version "0.0.1-SNAPSHOT"}}}}

$ neil version patch
v0.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant