Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove todo from nrepl version string #337

Open
benjamin-asdf opened this issue Sep 16, 2023 · 2 comments
Open

Remove todo from nrepl version string #337

benjamin-asdf opened this issue Sep 16, 2023 · 2 comments

Comments

@benjamin-asdf
Copy link
Contributor

In describe session we return some TODO strings.
Maybe just something like v1? BTW it doesn't break anything.

context:
clojure-emacs/cider#3467
@benjamin-asdf benjamin-asdf mentioned this issue Sep 16, 2023
Closed
6 tasks
@borkdude
Copy link
Collaborator

The version can be obtained from package.json

@borkdude
Copy link
Collaborator

Actually we already have a version constant somewhere, which is also used when you start a REPL, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@borkdude @benjamin-asdf