refactor(rollup)!: receive package patterns instead of config files (#65)

Author: olehan

.pnp.js

@@ -1,33 +1,47 @@
-import { RollupConfigInjectOptions } from '@azimutlabs/rollup-config';
+import { RollupConfig, RollupConfigInjectOptions } from '@azimutlabs/rollup-config';
 import { sync } from 'glob';
-import { dirname, resolve } from 'path';
-import readPkgUp from 'read-pkg-up';
+import { resolve } from 'path';
 import type { RollupOptions } from 'rollup';
 import loadConfigFile from 'rollup/dist/loadConfigFile';
 
-export const collect = async (
-  filePatterns: readonly string[],
-  cwd = process.cwd()
-): Promise<readonly RollupOptions[]> => {
-  const packagePath = readPkgUp.sync({ cwd })?.path ?? cwd;
-  const rootDir = dirname(packagePath);
-
-  const configPromises = filePatterns
-    .flatMap((pattern) => sync(pattern, { cwd: rootDir }) as readonly string[])
-    .map(async (file) => {
-      class InjectOptions extends RollupConfigInjectOptions {
-        // eslint-disable-next-line class-methods-use-this
-        public get rootDir(): string {
-          return dirname(file);
+const configFilePattern = 'rollup.config.@(js|mjs|cjs)';
+
+export function collect(
+  packages: readonly string[]
+): (dirname: string) => Promise<readonly RollupOptions[]>;
+export function collect(
+  packages: readonly string[]
+): (options: RollupOptions) => Promise<readonly RollupOptions[]>;
+export function collect(packages: readonly string[]) {
+  return async (dirnameOrOptions: RollupOptions | string): Promise<readonly RollupOptions[]> => {
+    const rootDir = RollupConfig.getRootDir(dirnameOrOptions);
+    const configPromises = packages
+      .flatMap((pattern) => sync(pattern, { cwd: rootDir }) as readonly string[])
+      .map(async (pkg) => {
+        const absolutePkgPath = resolve(rootDir, pkg);
+
+        const [firstFoundFile] = sync(configFilePattern, { cwd: absolutePkgPath });
+        if (!firstFoundFile) return null;
+
+        class InjectOptions extends RollupConfigInjectOptions {
+          // eslint-disable-next-line class-methods-use-this
+          public get rootDir(): string {
+            return absolutePkgPath;
+          }
         }
-      }
 
-      const { warnings, options } = await loadConfigFile(resolve(cwd, file), new InjectOptions());
+        const { warnings, options } = await loadConfigFile(
+          resolve(absolutePkgPath, firstFoundFile),
+          new InjectOptions()
+        );
 
-      warnings.flush();
+        warnings.flush();
 
-      return options;
-    });
+        return options;
+      });
 
-  return Promise.all(configPromises).then((configs) => configs.flat());
-};
+    return Promise.all(configPromises).then((configs) =>
+      configs.flat().filter((it): it is RollupOptions => it !== null)
+    );
+  };
+}

.yarn/cache/a-file-a3c0d44d94-35e9ca42e5.zip

@@ -1,17 +1,14 @@
-import { resolve } from 'path';
-import readPackage from 'read-pkg-up';
+import readPkgUp from 'read-pkg-up';
 
 import { sortDependencies } from './sortDependencies';
 
-const defaultConfigFile = 'rollup.config.@(js|mjs|cjs)';
-
-export const fromWorkspaces = (pattern = defaultConfigFile): readonly string[] => {
-  const foundPackage = readPackage.sync();
+export const fromWorkspaces = (): readonly string[] => {
+  const foundPackage = readPkgUp.sync();
   if (!foundPackage) return [];
 
   const { workspaces } = foundPackage.packageJson;
   if (!workspaces) return [];
 
   const spaces = Array.isArray(workspaces) ? workspaces : workspaces.packages;
-  return sortDependencies(spaces).map((workspace: string) => resolve(workspace, pattern));
+  return sortDependencies(spaces);
 };

.yarn/cache/c-file-083aeffd4e-7d3da9612b.zip

@@ -4286,23 +4286,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"a@file:../a::locator=b%40workspace%3Apackages%2Ftests%2Fsrc%2Frollup%2Fpackages%2Fb":
-  version: 0.0.0
-  resolution: "a@file:../a#../a::hash=49c627&locator=b%40workspace%3Apackages%2Ftests%2Fsrc%2Frollup%2Fpackages%2Fb"
-  dependencies:
-    c: "file:../c"
-  checksum: 35e9ca42e57cbd492b9d499dca48b5233116e4fb59f03c3b3e81e4ef602adb967f1ca877ef7ae492e180f5b30df942cc6eecd7a18960d850d8ae439684dfe0da
-  languageName: node
-  linkType: hard
-
-"a@workspace:packages/tests/src/rollup/packages/a":
-  version: 0.0.0-use.local
-  resolution: "a@workspace:packages/tests/src/rollup/packages/a"
-  dependencies:
-    c: "file:../c"
-  languageName: unknown
-  linkType: soft
-
 "abab@npm:^2.0.3":
   version: 2.0.5
   resolution: "abab@npm:2.0.5"
@@ -4767,15 +4750,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"b@workspace:packages/tests/src/rollup/packages/b":
-  version: 0.0.0-use.local
-  resolution: "b@workspace:packages/tests/src/rollup/packages/b"
-  dependencies:
-    a: "file:../a"
-    c: "file:../c"
-  languageName: unknown
-  linkType: soft
-
 "babel-jest@npm:^26.6.3":
   version: 26.6.3
   resolution: "babel-jest@npm:26.6.3"
@@ -5098,33 +5072,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"c@file:../c::locator=a%40file%3A..%2Fa%23..%2Fa%3A%3Ahash%3D49c627%26locator%3Db%2540workspace%253Apackages%252Ftests%252Fsrc%252Frollup%252Fpackages%252Fb":
-  version: 0.0.0
-  resolution: "c@file:../c#../c::hash=269aec&locator=a%40file%3A..%2Fa%23..%2Fa%3A%3Ahash%3D49c627%26locator%3Db%2540workspace%253Apackages%252Ftests%252Fsrc%252Frollup%252Fpackages%252Fb"
-  checksum: 7d3da9612be7b952116aaa48056651fe813dfbbb87a6809e7f1681a391501e29c80b912eabffb33364b43fec8705aad37119e2acbc50a0a5d21820b11110a22d
-  languageName: node
-  linkType: hard
-
-"c@file:../c::locator=a%40workspace%3Apackages%2Ftests%2Fsrc%2Frollup%2Fpackages%2Fa":
-  version: 0.0.0
-  resolution: "c@file:../c#../c::hash=269aec&locator=a%40workspace%3Apackages%2Ftests%2Fsrc%2Frollup%2Fpackages%2Fa"
-  checksum: 7d3da9612be7b952116aaa48056651fe813dfbbb87a6809e7f1681a391501e29c80b912eabffb33364b43fec8705aad37119e2acbc50a0a5d21820b11110a22d
-  languageName: node
-  linkType: hard
-
-"c@file:../c::locator=b%40workspace%3Apackages%2Ftests%2Fsrc%2Frollup%2Fpackages%2Fb":
-  version: 0.0.0
-  resolution: "c@file:../c#../c::hash=269aec&locator=b%40workspace%3Apackages%2Ftests%2Fsrc%2Frollup%2Fpackages%2Fb"
-  checksum: 7d3da9612be7b952116aaa48056651fe813dfbbb87a6809e7f1681a391501e29c80b912eabffb33364b43fec8705aad37119e2acbc50a0a5d21820b11110a22d
-  languageName: node
-  linkType: hard
-
-"c@workspace:packages/tests/src/rollup/packages/c":
-  version: 0.0.0-use.local
-  resolution: "c@workspace:packages/tests/src/rollup/packages/c"
-  languageName: unknown
-  linkType: soft
-
 "cacache@npm:^12.0.0, cacache@npm:^12.0.3":
   version: 12.0.4
   resolution: "cacache@npm:12.0.4"
@@ -5990,12 +5937,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"d@workspace:packages/tests/src/rollup/packages/d":
-  version: 0.0.0-use.local
-  resolution: "d@workspace:packages/tests/src/rollup/packages/d"
-  languageName: unknown
-  linkType: soft
-
 "dargs@npm:^4.0.1":
   version: 4.1.0
   resolution: "dargs@npm:4.1.0"
@@ -6352,12 +6293,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"e@workspace:packages/tests/src/rollup/packages/e":
-  version: 0.0.0-use.local
-  resolution: "e@workspace:packages/tests/src/rollup/packages/e"
-  languageName: unknown
-  linkType: soft
-
 "ecc-jsbn@npm:~0.1.1":
   version: 0.1.2
   resolution: "ecc-jsbn@npm:0.1.2"