Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract parsing arguments into separated function #158

Open
Abdujabbar opened this issue Aug 8, 2023 · 2 comments
Open

Extract parsing arguments into separated function #158

Abdujabbar opened this issue Aug 8, 2023 · 2 comments

Comments

@Abdujabbar
Copy link

Hello!

Just reviewed the source, and want to suggest, it would be better to manage if we can separate process of parsing arguments into a separate function.

https://github.com/azimjohn/jprq/blob/master/cli/main.go#L31-L70

method: parse_args - which would be parse arguments and will return a dictionary like in the python parse_args function, or raises an exception:

https://docs.python.org/3/library/argparse.html?highlight=argparse#module-argparse

@azimjohn
Copy link
Owner

azimjohn commented Aug 8, 2023

PR please!

@Abdujabbar
Copy link
Author

@azimjohn Ok, let I will do it. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants