Skip to content
This repository has been archived by the owner on Oct 8, 2022. It is now read-only.

Error when using output endpoint #15

Open
holms opened this issue Nov 23, 2018 · 4 comments
Open

Error when using output endpoint #15

holms opened this issue Nov 23, 2018 · 4 comments

Comments

@holms
Copy link

holms commented Nov 23, 2018

Seems to be it's invalid.

* module.redis_sharepass.output.endpoint: Resource 'aws_elasticache_replication_group.redis' does not have attribute 'primary_endpoint_address' for variable 'aws_elasticache_replication_group.redis.primary_endpoint_address'

According to docs this attribute is only for non-clustered redis:

primary_endpoint_address - (Redis only) The address of the 
endpoint for the primary node in the replication group, if the cluster mode is disabled. 

For clustered redis you need to you use this:

configuration_endpoint_address - The address of the replication group configuration endpoint when cluster mode is enabled. 
@hectcastro
Copy link
Contributor

Thanks for surfacing this. I don't think we have ever used this module with clustered Redis.

@holms
Copy link
Author

holms commented Nov 25, 2018

Well for single instance I believe it would be cheaper to have some docker container :) In production things should be false tolerant right :)?

@hectcastro
Copy link
Contributor

I was interpreting "clustered" Redis as an instance of Redis with Redis Cluster enabled. We've typically used ElastiCache replication groups to host Redis with a leader/follower setup for faster failover (but even with this, we still strive to make the application not depend on data in the cache).

I'm still wary about depending on the fault tolerance story of Redis Cluster in production given the history of Sentinel and Redis engine default persistence settings. :)

@holms
Copy link
Author

holms commented Nov 26, 2018

Oh alright I see. I've used parameter group for cluster parameter_group = "default.redis5.0.cluster.on"

Probably would be hard to implement this fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants