-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make callback Type FutureOr
#66
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The callbacks
onOpen
,onDismiss
andonComplete
are of typeFuture<bool>
. This leads to the problem that you always have to make the callback an async function even if the callback doesn't await something. This can be easily fixed by changing the callback type toFutureOr<bool>
. With this type, the function can be aFuture
but doesn't have to.The text was updated successfully, but these errors were encountered: