Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background dismissable is true on default should be changed to false #52

Open
barun1997 opened this issue Oct 10, 2020 · 3 comments
Open

Comments

@barun1997
Copy link

In the Overlay, the comments read:


 /// Controls whether the overlay should be dismissed on touching the background or not.
  ///
  /// The default value for [backgroundDismissible] is `true`.

However, the default value for backgroundDismissible is false.

@barun1997 barun1997 reopened this Oct 10, 2020
@barun1997
Copy link
Author

@MoacirSchmidt I think you misunderstood the changes requested. The default value for backgroundDismissible was false in the code, but the comments read that the value is true. So I was requesting for the comment to be updated.

@MoacirSchmidt
Copy link

MoacirSchmidt commented Jun 3, 2021

You are right. I am sorry. I deleted my comment

@barun1997
Copy link
Author

@MoacirSchmidt No worries! Have a wonderful day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants