Fix: xrpl remote deployment (2) (#711)

Author: dfapel

apps/maestro/src/features/CanonicalTokenDeployment/steps/deploy-and-register/DeployAndRegister.tsx

@@ -25,7 +25,7 @@ import { RegisterCanonicalTokenResult } from "~/features/suiHooks/useRegisterCan
 import { useTransactionsContainer } from "~/features/Transactions";
 import { useBalance, useChainId } from "~/lib/hooks";
 import { handleTransactionResult } from "~/lib/transactions/handlers";
-import { filterEligibleChains } from "~/lib/utils/chains";
+import { filterEligibleChainsForRemoteDeployment } from "~/lib/utils/chains";
 import { getNativeToken } from "~/lib/utils/getNativeToken";
 import ChainPicker from "~/ui/compounds/ChainPicker";
 import { NextButton, TokenNameAlert } from "~/ui/compounds/MultiStepForm";
@@ -258,7 +258,7 @@ export const Step3: FC = () => {
     ]
   );
 
-  const eligibleChains = filterEligibleChains(state.chains, chainId);
+  const eligibleChains = filterEligibleChainsForRemoteDeployment(state.chains, chainId);
 
   const formSubmitRef = useRef<ComponentRef<"button">>(null);
 

apps/maestro/src/features/InterchainTokenDeployment/steps/deploy-and-register/DeployAndRegister.tsx

@@ -4,7 +4,7 @@ import { ComponentRef, useMemo, useRef, type FC } from "react";
 import { parseUnits } from "viem";
 
 import { useBalance, useChainId } from "~/lib/hooks";
-import { filterEligibleChains } from "~/lib/utils/chains";
+import { filterEligibleChainsForRemoteDeployment } from "~/lib/utils/chains";
 import { getNativeToken } from "~/lib/utils/getNativeToken";
 import ChainPicker from "~/ui/compounds/ChainPicker";
 import { NextButton } from "~/ui/compounds/MultiStepForm";
@@ -31,7 +31,7 @@ export const Step2: FC = () => {
 
   const { handleSubmit, isReady } = useHandleSubmit();
 
-  const eligibleChains = filterEligibleChains(state.chains, chainId);
+  const eligibleChains = filterEligibleChainsForRemoteDeployment(state.chains, chainId);
 
   const formSubmitRef = useRef<ComponentRef<"button">>(null);
 

apps/maestro/src/lib/utils/chains.ts

@@ -1,3 +1,4 @@
+import { CHAINS_WITHOUT_DEPLOYMENT } from "~/config/chains";
 import { NEXT_PUBLIC_WHITELISTED_DEST_CHAINS_FOR_VM } from "~/config/env";
 import { ITSChainConfig } from "~/server/chainConfig";
 
@@ -8,8 +9,9 @@ type ChainConfigIndex = {
 };
 
 /**
- * Filters out destination chains that are not eligible for the current chain vm chain.
+ * Filters out destination chains that are not eligible for the current chain vm chain for ITS transfers.
  * Currently, only VM chains are eligible for the current chain type.
+ * Use filterEligibleChainsForRemoteDeployment instead to get the chains that support remote deployments 
  * @param destinationChains - The list of chains to filter.
  * @param currentChainId - The ID of the current chain.
  * @returns A filtered list of chains.
@@ -52,6 +54,16 @@ export const filterEligibleChains = (
   });
 };
 
+export const filterEligibleChainsForRemoteDeployment = (
+  destinationChains: ITSChainConfig[],
+  currentChainId: number
+): ITSChainConfig[] => {
+  const eligibleDestinationChains = filterEligibleChains(destinationChains, currentChainId);
+  return eligibleDestinationChains.filter((chain) => (
+    !CHAINS_WITHOUT_DEPLOYMENT.includes(chain.chain_id)
+  ));
+};
+
 /**
  * Retrieves the chain configuration based on the provided Axelar chain ID.
  * Handles the special case where the axelarChainId is "axelar".

apps/maestro/src/ui/pages/InterchainTokenDetailsPage/ConnectedInterchainTokensPage.tsx

@@ -404,8 +404,7 @@ const ConnectedInterchainTokensPage: FC<ConnectedInterchainTokensPageProps> = (
     tokenAddress: props.tokenAddress,
   });
 
-  // eslint-disable-next-line prefer-const
-  let [registered, unregistered] = Maybe.of(interchainToken?.matchingTokens)
+  const [registered, unregisteredUnfiltered] = Maybe.of(interchainToken?.matchingTokens)
     .map(
       map(
         (token) =>
@@ -424,7 +423,7 @@ const ConnectedInterchainTokensPage: FC<ConnectedInterchainTokensPageProps> = (
 
   // There are some chains where we cannot remote deploy to
   // Thus, we need to remove these chains from the `unregistered` object.
-  unregistered = unregistered.filter((token) => !(CHAINS_WITHOUT_DEPLOYMENT.includes(token.chainId)));
+  const unregistered = unregisteredUnfiltered.filter((token) => !CHAINS_WITHOUT_DEPLOYMENT.includes(token.chainId));
 
   const destinationChainIds = useMemo(
     () =>