Skip to content

Enabling --write_hist_log=foo fails if ZLIB not enabled #1996

@egouriou-google

Description

@egouriou-google

Description of the bug:
Running a local build of fio (no client/server setup), and attempting to use --write_hist_log=, we get a failure due to this check in init.c (l.1771 at HEAD):

#ifndef CONFIG_ZLIB
		if (td->client_type) {
			log_err("fio: --write_hist_log requires zlib in client/server mode\n");
			goto err;
		}
#endif

client_type is always non-zero since FIO_CLIENT_TYPE_CLI is 1, _GUI is 2.

Environment: Linux version 6.6.64, x86

fio version: fio-3.36.0

Reproduction steps

# cat > ./aio.fio
[global]
direct=1
iodepth=1
thread=1
ioengine=libaio
rw=randread
blocksize=4k
size=1G
numjobs=1
time_based=1
group_reporting=1
ramp_time=2
runtime=2
new_group

[nvme0uq1]
filename=/dev/nvme0n1

# ./fio --write_hist_log=foo --log_hist_msec=100 ./aio.fio
fio: --write_hist_log requires zlib in client/server mode

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions