Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node version of lib includes large dependency jshint #87

Open
TakesTheBiscuit opened this issue Mar 18, 2020 · 4 comments
Open

Node version of lib includes large dependency jshint #87

TakesTheBiscuit opened this issue Mar 18, 2020 · 4 comments
Assignees
@IanMeyers

Comments

@TakesTheBiscuit
Copy link
Contributor

JSHINT files in the /dist directory were > 2 MB

This meant any lambda functions using this node lib were minimum 2MB without anything else included.

Searched codebase for jshint and found a single reference to it - IMO this is a dev dependency by definition.
@TakesTheBiscuit TakesTheBiscuit mentioned this issue Mar 18, 2020
Merged
@IanMeyers
Copy link
Contributor

Thanks for pointing this out - will try to find some time tomorrow to fix it, or happy to take a PR.

@IanMeyers IanMeyers self-assigned this Mar 18, 2020
@TakesTheBiscuit
Copy link
Contributor Author

PR is in already

@TakesTheBiscuit
Copy link
Contributor Author

Wow, that was fast!

@TakesTheBiscuit
Copy link
Contributor Author

@IanMeyers were we supposed to bump the package number of the lib itself, sorry may have been an oversight on my part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IanMeyers IanMeyers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IanMeyers @TakesTheBiscuit