fix: Remove trailing curly from wildcard bucket arn (#514)

dacort · Damon P. Cortesi · web-flow · commit 1b59017838ac · 2024-05-02T10:32:38.000-07:00
Co-authored-by: Damon P. Cortesi &lt;damon.cortesi@airbnb.com&gt;
diff --git a/ai-ml/mlflow/addons.tf b/ai-ml/mlflow/addons.tf
@@ -89,7 +89,7 @@ module "eks_blueprints_addons" {
   aws_for_fluentbit = {
     s3_bucket_arns = [
       module.fluentbit_s3_bucket.s3_bucket_arn,
-      "${module.fluentbit_s3_bucket.s3_bucket_arn}/*}"
+      "${module.fluentbit_s3_bucket.s3_bucket_arn}/*"
     ]
     values = [templatefile("${path.module}/helm-values/aws-for-fluentbit-values.yaml", {
       region               = local.region,
diff --git a/ai-ml/trainium-inferentia/addons.tf b/ai-ml/trainium-inferentia/addons.tf
@@ -178,7 +178,7 @@ module "eks_blueprints_addons" {
   aws_for_fluentbit = {
     s3_bucket_arns = [
       module.s3_bucket.s3_bucket_arn,
-      "${module.s3_bucket.s3_bucket_arn}/*}"
+      "${module.s3_bucket.s3_bucket_arn}/*"
     ]
     values = [templatefile("${path.module}/helm-values/aws-for-fluentbit-values.yaml", {
       region               = local.region,
diff --git a/analytics/terraform/emr-eks-karpenter/addons.tf b/analytics/terraform/emr-eks-karpenter/addons.tf
@@ -140,7 +140,7 @@ module "eks_blueprints_addons" {
   aws_for_fluentbit = {
     s3_bucket_arns = [
       module.s3_bucket.s3_bucket_arn,
-      "${module.s3_bucket.s3_bucket_arn}/*}"
+      "${module.s3_bucket.s3_bucket_arn}/*"
     ]
     values = [templatefile("${path.module}/helm-values/aws-for-fluentbit-values.yaml", {
       region               = local.region,
diff --git a/analytics/terraform/spark-k8s-operator/addons.tf b/analytics/terraform/spark-k8s-operator/addons.tf
@@ -115,7 +115,7 @@ module "eks_blueprints_addons" {
   aws_for_fluentbit = {
     s3_bucket_arns = [
       module.s3_bucket.s3_bucket_arn,
-      "${module.s3_bucket.s3_bucket_arn}/*}"
+      "${module.s3_bucket.s3_bucket_arn}/*"
     ]
     values = [templatefile("${path.module}/helm-values/aws-for-fluentbit-values.yaml", {
       region               = local.region,
diff --git a/distributed-databases/trino/addons.tf b/distributed-databases/trino/addons.tf
@@ -137,7 +137,7 @@ module "eks_blueprints_addons" {
   aws_for_fluentbit = {
     s3_bucket_arns = [
       module.s3_bucket.s3_bucket_arn,
-      "${module.s3_bucket.s3_bucket_arn}/*}"
+      "${module.s3_bucket.s3_bucket_arn}/*"
     ]
     values = [templatefile("${path.module}/helm-values/aws-for-fluentbit-values.yaml", {
       region               = local.region,
diff --git a/schedulers/terraform/argo-workflow/addons.tf b/schedulers/terraform/argo-workflow/addons.tf
@@ -136,7 +136,7 @@ module "eks_blueprints_addons" {
   aws_for_fluentbit = {
     s3_bucket_arns = [
       module.s3_bucket.s3_bucket_arn,
-      "${module.s3_bucket.s3_bucket_arn}/*}"
+      "${module.s3_bucket.s3_bucket_arn}/*"
     ]
     values = [templatefile("${path.module}/helm-values/aws-for-fluentbit-values.yaml", {
       region               = local.region,

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ module "eks_blueprints_addons" {`
`89`	`89`	`aws_for_fluentbit = {`
`90`	`90`	`s3_bucket_arns = [`
`91`	`91`	`module.fluentbit_s3_bucket.s3_bucket_arn,`
`92`		`- "${module.fluentbit_s3_bucket.s3_bucket_arn}/*}"`
	`92`	`+ "${module.fluentbit_s3_bucket.s3_bucket_arn}/*"`
`93`	`93`	`]`
`94`	`94`	`values = [templatefile("${path.module}/helm-values/aws-for-fluentbit-values.yaml", {`
`95`	`95`	`region = local.region,`
Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ module "eks_blueprints_addons" {`
`178`	`178`	`aws_for_fluentbit = {`
`179`	`179`	`s3_bucket_arns = [`
`180`	`180`	`module.s3_bucket.s3_bucket_arn,`
`181`		`- "${module.s3_bucket.s3_bucket_arn}/*}"`
	`181`	`+ "${module.s3_bucket.s3_bucket_arn}/*"`
`182`	`182`	`]`
`183`	`183`	`values = [templatefile("${path.module}/helm-values/aws-for-fluentbit-values.yaml", {`
`184`	`184`	`region = local.region,`
Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ module "eks_blueprints_addons" {`
`140`	`140`	`aws_for_fluentbit = {`
`141`	`141`	`s3_bucket_arns = [`
`142`	`142`	`module.s3_bucket.s3_bucket_arn,`
`143`		`- "${module.s3_bucket.s3_bucket_arn}/*}"`
	`143`	`+ "${module.s3_bucket.s3_bucket_arn}/*"`
`144`	`144`	`]`
`145`	`145`	`values = [templatefile("${path.module}/helm-values/aws-for-fluentbit-values.yaml", {`
`146`	`146`	`region = local.region,`
Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ module "eks_blueprints_addons" {`
`115`	`115`	`aws_for_fluentbit = {`
`116`	`116`	`s3_bucket_arns = [`
`117`	`117`	`module.s3_bucket.s3_bucket_arn,`
`118`		`- "${module.s3_bucket.s3_bucket_arn}/*}"`
	`118`	`+ "${module.s3_bucket.s3_bucket_arn}/*"`
`119`	`119`	`]`
`120`	`120`	`values = [templatefile("${path.module}/helm-values/aws-for-fluentbit-values.yaml", {`
`121`	`121`	`region = local.region,`
Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ module "eks_blueprints_addons" {`
`137`	`137`	`aws_for_fluentbit = {`
`138`	`138`	`s3_bucket_arns = [`
`139`	`139`	`module.s3_bucket.s3_bucket_arn,`
`140`		`- "${module.s3_bucket.s3_bucket_arn}/*}"`
	`140`	`+ "${module.s3_bucket.s3_bucket_arn}/*"`
`141`	`141`	`]`
`142`	`142`	`values = [templatefile("${path.module}/helm-values/aws-for-fluentbit-values.yaml", {`
`143`	`143`	`region = local.region,`
Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ module "eks_blueprints_addons" {`
`136`	`136`	`aws_for_fluentbit = {`
`137`	`137`	`s3_bucket_arns = [`
`138`	`138`	`module.s3_bucket.s3_bucket_arn,`
`139`		`- "${module.s3_bucket.s3_bucket_arn}/*}"`
	`139`	`+ "${module.s3_bucket.s3_bucket_arn}/*"`
`140`	`140`	`]`
`141`	`141`	`values = [templatefile("${path.module}/helm-values/aws-for-fluentbit-values.yaml", {`
`142`	`142`	`region = local.region,`