Skip to content

optimize file based streams #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aajtodd opened this issue Jul 7, 2021 · 3 comments
Closed

optimize file based streams #227

aajtodd opened this issue Jul 7, 2021 · 3 comments
Labels
no-auto-closure We do not want this issue to be automatically closed.

Comments

@aajtodd
Copy link
Contributor

aajtodd commented Jul 7, 2021

It's not particularly efficient to have to launch a coroutine and proxy an SdkByteReadChannel to CRT. We should probably consider special casing file inputs such that we don't have to cross the JNI boundary for signing and uploading content.

See awslabs/aws-crt-java#308 which blocks this. We would also need a way to get at the file through HttpBody, see https://github.com/awslabs/smithy-kotlin/issues/297 for some ideas.

@aajtodd aajtodd transferred this issue from smithy-lang/smithy-kotlin Jul 8, 2021
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This is a very old issue that is probably not getting as much attention as it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to provide a comment or open a new issue.

@github-actions github-actions bot added closing-soon This issue will automatically close in 2 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 2 days unless further comments are made. labels Jul 8, 2022
@ianbotsf ianbotsf added no-auto-closure We do not want this issue to be automatically closed. and removed closed-for-staleness labels Jul 11, 2022
@ianbotsf ianbotsf reopened this Jul 11, 2022
@aajtodd
Copy link
Contributor Author

aajtodd commented Sep 13, 2023

We've significantly refactored the I/O model as well as implemented signing directly in Kotlin since this issue was opened. Closing as there is no signs this is actually any kind of bottleneck, we can always re-evaluate with concrete use cases/issues if that isn't the case.

@aajtodd aajtodd closed this as completed Sep 13, 2023
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-auto-closure We do not want this issue to be automatically closed.
Projects
None yet
Development

No branches or pull requests

2 participants