-
Notifications
You must be signed in to change notification settings - Fork 52
optimize file based streams #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is a very old issue that is probably not getting as much attention as it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to provide a comment or open a new issue. |
We've significantly refactored the I/O model as well as implemented signing directly in Kotlin since this issue was opened. Closing as there is no signs this is actually any kind of bottleneck, we can always re-evaluate with concrete use cases/issues if that isn't the case. |
|
It's not particularly efficient to have to launch a coroutine and proxy an
SdkByteReadChannel
to CRT. We should probably consider special casing file inputs such that we don't have to cross the JNI boundary for signing and uploading content.See awslabs/aws-crt-java#308 which blocks this. We would also need a way to get at the file through HttpBody, see https://github.com/awslabs/smithy-kotlin/issues/297 for some ideas.
The text was updated successfully, but these errors were encountered: