Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer is now only available as a polyfill on the new vite builds. Module "buffer" has been externalized for browser compatibility #748

Open
jpengelbrecht opened this issue Aug 17, 2023 · 1 comment
Labels
p2 to-be-reproduced We need to reproduce this issue

Comments

@jpengelbrecht
Copy link

Basically this means that this module will not work out of the box for any new builds as we need to add buffer to polyfills then the link it to the window object manually for this module to now work.

Ideally I would be awesome if this module could import buffer as a dependancy. so npm install buffer and use it from an import it instead of just calling Buffer as an internal module.

@jpengelbrecht
Copy link
Author

made a fix here #749

@svidgen svidgen added to-be-reproduced We need to reproduce this issue p2 labels Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 to-be-reproduced We need to reproduce this issue
Projects
None yet
Development

No branches or pull requests

2 participants