Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependencies in aws-appsync-auth-link package? #695

Open
SverrirV opened this issue Nov 17, 2021 · 1 comment
Open

Missing dependencies in aws-appsync-auth-link package? #695

SverrirV opened this issue Nov 17, 2021 · 1 comment

Comments

@SverrirV
Copy link

Note: If your issue/feature-request/question is regarding the AWS AppSync service, please log it in the
official AWS AppSync forum

Do you want to request a feature or report a bug?
Reporting a potential bug

What is the current behavior?
Buffer is not found when using aws-appsync-auth-link pacakge with React Native.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
include the aws-appsync-auth-link package to a react-native project. Use it to implement Apollo v3 with Appsync.

What is the expected behavior?
Buffer package to be included in the aws-appsync-auth-link pacakge dependencies

Which versions and which environment (browser, react-native, nodejs) / OS are affected by this issue? Did this work in previous versions?
React-Native: 0.66
aws-appsync-auth-link: 3.0.7

I was following the instructions on how to create an Appsync link for Apollo v3 and I notice that the signer.ts has this line at the top.

global.Buffer = global.Buffer || require('buffer').Buffer; // Required for aws sigv4 signing

require("buffer") will fail unless you manually install the buffer package your self since it is not included in the aws-appsync-auth-link dependencies.

Was not sure if I should create a issue for this but feel that if signer.ts file tries to require it, it should be included in the dependencies.

@butterybread
Copy link

butterybread commented Jul 27, 2022

I am using yarn with pnp.
For me the issue was resolved by declaring the missing dependencies.

.yarnrc.yml

yarnPath: .yarn/releases/yarn-3.2.1.cjs
packageExtensions:
  aws-appsync-subscription-link@*:
    dependencies:
      uuid: "*"
  aws-appsync-auth-link@*:
    dependencies:
      url: "*"
      buffer: "*"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants