From cf5ae3326200ef502c01418907bce2846f22a755 Mon Sep 17 00:00:00 2001 From: Jason Weill <93281816+JasonWeill@users.noreply.github.com> Date: Tue, 17 Oct 2023 17:12:45 -0700 Subject: [PATCH] Adds jupyter-lsp, python-lsp-server, and notebook to 1.0.0 beta (#82) * Adds jupyter-lsp and notebook to test harness * Reinstates test suites * Revert "Release v0.7.0 (#75)" This reverts commit 5234f457425a2537f9aa940da3360bb9cd8ef811. * Revert "Revert "Release v0.7.0 (#75)"" This reverts commit b8b8d1a1daa5865dfa6b6c8ed7ff6e608c503d70. * Adds python-lsp-server test * Adds python-lsp-server to test harness --------- Co-authored-by: Jason Weill --- test/test_artifacts/v1/jupyter-lsp.test.Dockerfile | 6 ++++++ test/test_artifacts/v1/notebook.test.Dockerfile | 6 ++++++ .../v1/python-lsp-server.test.Dockerfile | 7 +++++++ test/test_dockerfile_based_harness.py | 10 ++++++++-- 4 files changed, 27 insertions(+), 2 deletions(-) create mode 100644 test/test_artifacts/v1/jupyter-lsp.test.Dockerfile create mode 100644 test/test_artifacts/v1/notebook.test.Dockerfile create mode 100644 test/test_artifacts/v1/python-lsp-server.test.Dockerfile diff --git a/test/test_artifacts/v1/jupyter-lsp.test.Dockerfile b/test/test_artifacts/v1/jupyter-lsp.test.Dockerfile new file mode 100644 index 00000000..812ca824 --- /dev/null +++ b/test/test_artifacts/v1/jupyter-lsp.test.Dockerfile @@ -0,0 +1,6 @@ +ARG COSMOS_IMAGE +FROM $COSMOS_IMAGE + +ARG MAMBA_DOCKERFILE_ACTIVATE=1 + +CMD ["python", "-c", "import jupyter_lsp"] diff --git a/test/test_artifacts/v1/notebook.test.Dockerfile b/test/test_artifacts/v1/notebook.test.Dockerfile new file mode 100644 index 00000000..16ca7e39 --- /dev/null +++ b/test/test_artifacts/v1/notebook.test.Dockerfile @@ -0,0 +1,6 @@ +ARG COSMOS_IMAGE +FROM $COSMOS_IMAGE + +ARG MAMBA_DOCKERFILE_ACTIVATE=1 + +CMD ["python", "-c", "import notebook"] diff --git a/test/test_artifacts/v1/python-lsp-server.test.Dockerfile b/test/test_artifacts/v1/python-lsp-server.test.Dockerfile new file mode 100644 index 00000000..24b38e7f --- /dev/null +++ b/test/test_artifacts/v1/python-lsp-server.test.Dockerfile @@ -0,0 +1,7 @@ +ARG COSMOS_IMAGE +FROM $COSMOS_IMAGE + +ARG MAMBA_DOCKERFILE_ACTIVATE=1 + +# "Confirm that installation succeeded" by running this - https://github.com/python-lsp/python-lsp-server#installation +CMD ["pylsp", "--help"] diff --git a/test/test_dockerfile_based_harness.py b/test/test_dockerfile_based_harness.py index cdf7f942..0d8b885c 100644 --- a/test/test_dockerfile_based_harness.py +++ b/test/test_dockerfile_based_harness.py @@ -27,7 +27,10 @@ ("sm-python-sdk.test.Dockerfile", ['sagemaker-python-sdk']), ("pytorch.examples.Dockerfile", ['pytorch']), ("tensorflow.examples.Dockerfile", ['tensorflow']), - ("jupyter-ai.test.Dockerfile", ['jupyter-ai'])]) + ("jupyter-ai.test.Dockerfile", ['jupyter-ai']), + ("jupyter-lsp.test.Dockerfile", ['jupyter-lsp']), + ("jupyter-lsp-server.test.Dockerfile", ['jupyter-lsp-server']), + ("notebook.test.Dockerfile", ['notebook'])]) def test_dockerfiles_for_cpu(dockerfile_path: str, required_packages: List[str], local_image_version: str, use_gpu: bool): _validate_docker_images(dockerfile_path, required_packages, local_image_version, use_gpu, 'cpu') @@ -45,7 +48,10 @@ def test_dockerfiles_for_cpu(dockerfile_path: str, required_packages: List[str], ("sm-python-sdk.test.Dockerfile", ['sagemaker-python-sdk']), ("pytorch.examples.Dockerfile", ['pytorch']), ("tensorflow.examples.Dockerfile", ['tensorflow']), - ("jupyter-ai.test.Dockerfile", ['jupyter-ai'])]) + ("jupyter-ai.test.Dockerfile", ['jupyter-ai']), + ("jupyter-lsp.test.Dockerfile", ['jupyter-lsp']), + ("jupyter-lsp-server.test.Dockerfile", ['jupyter-lsp-server']), + ("notebook.test.Dockerfile", ['notebook'])]) def test_dockerfiles_for_gpu(dockerfile_path: str, required_packages: List[str], local_image_version: str, use_gpu: bool): _validate_docker_images(dockerfile_path, required_packages, local_image_version, use_gpu, 'gpu')