Skip to content

Commit b610971

Browse files
kumarnztdylanraws
authored andcommitted
feature: Add dependencies for amazon-sagemaker-sql extension
1 parent 4fd13e2 commit b610971

File tree

5 files changed

+24
-4
lines changed

5 files changed

+24
-4
lines changed
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
11
conda-forge::jupyter_server_fileid
2-
conda-forge::jupyter_ydoc
2+
conda-forge::jupyter_ydoc
3+
conda-forge::amazon_sagemaker_sql_editor[version='>=0.1.0,<2']
4+
conda-forge::amazon-sagemaker-sql-magic[version='>=0.1.0,<2']
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
11
conda-forge::jupyter_server_fileid
2-
conda-forge::jupyter_ydoc
2+
conda-forge::jupyter_ydoc
3+
conda-forge::amazon_sagemaker_sql_editor[version='>=0.1.0,<2']
4+
conda-forge::amazon-sagemaker-sql-magic[version='>=0.1.0,<2']
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
ARG COSMOS_IMAGE
2+
FROM $COSMOS_IMAGE
3+
4+
ARG MAMBA_DOCKERFILE_ACTIVATE=1
5+
6+
CMD ["python", "-c", "import amazon_sagemaker_sql_magic"]
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
ARG COSMOS_IMAGE
2+
FROM $COSMOS_IMAGE
3+
4+
ARG MAMBA_DOCKERFILE_ACTIVATE=1
5+
6+
CMD ["python", "-c", "import amazon_sagemaker_sql_editor"]

test/test_dockerfile_based_harness.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,9 @@
4040
("jupyterlab-git.test.Dockerfile", ['jupyterlab-git']),
4141
("serve.test.Dockerfile", ['serve-langchain']),
4242
("jupyter-server-fileid.test.Dockerfile", ['jupyter_server_fileid']),
43-
("jupyter-ydoc.test.Dockerfile", ['jupyter_ydoc'])])
43+
("jupyter-ydoc.test.Dockerfile", ['jupyter_ydoc'])],
44+
("amazon-sagemaker-sql-magic.test.Dockerfile", ['amazon-sagemaker-sql-magic']),
45+
("amazon_sagemaker_sql_editor.test.Dockerfile", ['amazon_sagemaker_sql_editor']))
4446
def test_dockerfiles_for_cpu(dockerfile_path: str, required_packages: List[str],
4547
local_image_version: str, use_gpu: bool):
4648
_validate_docker_images(dockerfile_path, required_packages, local_image_version, use_gpu, 'cpu')
@@ -72,7 +74,9 @@ def test_dockerfiles_for_cpu(dockerfile_path: str, required_packages: List[str],
7274
("jupyterlab-git.test.Dockerfile", ['jupyterlab-git']),
7375
("serve.test.Dockerfile", ['serve-langchain']),
7476
("jupyter-server-fileid.test.Dockerfile", ['jupyter_server_fileid']),
75-
("jupyter-ydoc.test.Dockerfile", ['jupyter_ydoc'])])
77+
("jupyter-ydoc.test.Dockerfile", ['jupyter_ydoc'])],
78+
("amazon-sagemaker-sql-magic.test.Dockerfile", ['amazon-sagemaker-sql-magic']),
79+
("amazon_sagemaker_sql_editor.test.Dockerfile", ['amazon_sagemaker_sql_editor']))
7680
def test_dockerfiles_for_gpu(dockerfile_path: str, required_packages: List[str],
7781
local_image_version: str, use_gpu: bool):
7882
_validate_docker_images(dockerfile_path, required_packages, local_image_version, use_gpu, 'gpu')

0 commit comments

Comments
 (0)