From 1d40c554fd155a586ce7ab641aac2b155f9d2a1d Mon Sep 17 00:00:00 2001 From: Clayton Parnell <42805768+claytonparnell@users.noreply.github.com> Date: Fri, 31 May 2024 14:55:49 -0400 Subject: [PATCH] fix: Minor readme fixes (#426) --- CONTRIBUTING.md | 4 ++-- DEVELOPMENT.md | 2 +- README.md | 2 -- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 324d899c..f3c45aac 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -74,14 +74,14 @@ Follow these steps for sending out a pull request for adding new packages: # If NEXT_VERSION is a new minor version: - python src/main.py create-minor-version-artifacts --base-patch-version=$BASE_PATCH_VERSION --force + python ./src/main.py create-minor-version-artifacts --base-patch-version=$BASE_PATCH_VERSION --force # Or for a new major version: python src/main.py create-major-version-artifacts --base-patch-version=$BASE_PATCH_VERSION --force # Build the image: - python src/main.py build \ + python ./src/main.py build \ --target-patch-version=$NEXT_VERSION --skip-tests ``` diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md index 2b9d61df..6840ac9b 100644 --- a/DEVELOPMENT.md +++ b/DEVELOPMENT.md @@ -15,7 +15,7 @@ against an Amazon SageMaker Distribution image: this could be a pre-built image an image that you built locally using the `build` command: ```shell -python main.py build --target-patch-version x.y.z +python ./src/main.py build --target-patch-version x.y.z ``` Run the following to invoke those tests: diff --git a/README.md b/README.md index 5fc7e122..2e275ed9 100644 --- a/README.md +++ b/README.md @@ -79,7 +79,6 @@ The easiest way to get it running on your laptop is through the Docker CLI: export ECR_IMAGE_ID='INSERT_IMAGE_YOU_WANT_TO_USE' docker run -it \ -p 8888:8888 \ - --user `id -u`:`id -g` \ -v `pwd`/sample-notebooks:/home/sagemaker-user/sample-notebooks \ $ECR_IMAGE_ID jupyter-lab --no-browser --ip=0.0.0.0 ``` @@ -94,7 +93,6 @@ export ECR_IMAGE_ID='INSERT_IMAGE_YOU_WANT_TO_USE' docker run -it \ -p 8888:8888 \ --entrypoint entrypoint-jupyter-server \ - --user `id -u`:`id -g` \ -v `pwd`/sample-notebooks:/home/sagemaker-user/sample-notebooks \ $ECR_IMAGE_ID ```