-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid storing signature schemes in a separate buffer #4543
Labels
Comments
In case it helps: I started on but I guess never finished this last year e088cb7 I'm not sure why I thought skipping extensions was necessary there though, we should just be able to have a separate "process" method we call after receiving the extension, like we do to calculate the PSK binders. |
goatgoose
added
priority/medium
Rank 3
size/medium
and removed
priority/high
Rank 2
labels
May 23, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem:
Currently the peer's signature schemes are read into the iana_list buffer. This limits the number of possible signature schemes the peer is allowed to send, since the buffer has a fixed size. If too many signature schemes are received, the connection fails.
Solution:
Rather than copy the signature schemes into a separate buffer, the signature schemes should instead be read straight from the client hello/certificate request.
The text was updated successfully, but these errors were encountered: