-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for overriding default hostname type #6097
Comments
@stevehipwell Is this a launch template configuration setting? |
@jonathan-innis I think it is. However the general docs which says that you can use the resource name for hostname in all scenarios is contradicted in other documents. I think this is still useful if you need an IPv6 enabled subnet, but less compelling. |
I can confirm that it's a launch template configuration setting. I'm not sure what docs you're referring to @stevehipwell, but I just tried launching an EC2 instance in an IPv4-only VPC with the "resource name" hostname type and it definitely configured the hostname accordingly. I'd love to see this feature! EDIT: my read of the launch template design doc suggests that we might not want a control knob for this. If that's the case, then I argue that we should always configure the launch template to use the "resource name" configuration setting, because the default configuration setting of "IP Name" is referred to as a legacy naming scheme in the docs. As an added bonus, it sounds like this would make kops and eks more consistent? Happy to try my hand at a PR for this if I can get some guidance on making this behavior always true vs making it opt-in/configurable. |
Tried to use this with karpenter
|
Update: it does not work with "EKS API" auth in EKS. Only works with "ConfigMap" auth, exactly as written in docs. Node name in k8s and EC2 "Name" tag becomes "i-xxx". But actual hostname of OS still is "ip-x-x-x-x" |
Description
What problem are you trying to solve?
I'd like to be able to override the subnet default hostname type for EC2 instances created by Karpenter.
How important is this feature to you?
This is a nice to have based on consistency with nodes created from an autoscaling group & launch template pattern.
The text was updated successfully, but these errors were encountered: